Repository navigation
Algorithms & Data Structure - Assignment 1 - #1
Open
mchebotarov wants to merge 2 commits into
Open
mchebotarov wants to merge 2 commits into
mchebotarov wants to merge 2 commits into
Conversation
added 2 commits
October 21, 2026 22:44
tianyi21
approved these changes
Oct 27, 2026
tianyi21
left a comment
There was a problem hiding this comment.
Hi Michael,
Thank you for submitting your ADS A1.
1️⃣ Problem Understanding ✅
- You demonstrated your understanding to your assigned problem.
- You created two new examples of your assigned problem.
2️⃣ Coding ✅💬
- Your Python code runs successfully without any errors.
- Your program produces the intended results.
- You clearly explained your implementation.
- 💬 [Efficiency] In addition to move non-zero elements to the front with the
current_modify_indexpointer, you may at the same time change the original location to zero. In this case, the secondforloop is no longer required. Although theO()is the same, this only requires one pass through the list.
3️⃣ Analysis ✅
- You correctly analyzed the time and space complexities of your solution.
4️⃣ Alternative Solution ✅
- You proposed an alternative solution to the problem.
📝 A1 Final Result
✅ Passed with 💬 comments. Please read through the comments above. If you need any help, please don't hesitate to let me know. Your A1 is now complete. You may merge this pull request.
Best,
Tianyi - ADS Learning Support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Adding code
What did you learn from the changes you have made?
Solving programming puzzles, and learning about space/time complexity
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Creating a new list instead of changing values in-place
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
No challenges
How were these changes tested?
I used 4 test cases to confirm
A reference to a related issue in your repository (if applicable)
Checklist