Skip to content

Algorithms & Data Structure - Assignment 1 - #1

Open
mchebotarov wants to merge 2 commits into
mainfrom
assignment-1
Open

mchebotarov wants to merge 2 commits into
mainfrom
assignment-1

Conversation

@mchebotarov

Copy link
Copy Markdown
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

Adding code

What did you learn from the changes you have made?

Solving programming puzzles, and learning about space/time complexity

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

Creating a new list instead of changing values in-place

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

No challenges

How were these changes tested?

I used 4 test cases to confirm

A reference to a related issue in your repository (if applicable)

Checklist

  • [ X] I can confirm that my changes are working as intended

@tianyi21 tianyi21 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Michael,

Thank you for submitting your ADS A1.

1️⃣ Problem Understanding ✅

  • You demonstrated your understanding to your assigned problem.
  • You created two new examples of your assigned problem.

2️⃣ Coding ✅💬

  • Your Python code runs successfully without any errors.
  • Your program produces the intended results.
  • You clearly explained your implementation.
  • 💬 [Efficiency] In addition to move non-zero elements to the front with the current_modify_index pointer, you may at the same time change the original location to zero. In this case, the second for loop is no longer required. Although the O() is the same, this only requires one pass through the list.

3️⃣ Analysis ✅

  • You correctly analyzed the time and space complexities of your solution.

4️⃣ Alternative Solution ✅

  • You proposed an alternative solution to the problem.

📝 A1 Final Result

✅ Passed with 💬 comments. Please read through the comments above. If you need any help, please don't hesitate to let me know. Your A1 is now complete. You may merge this pull request.

Best,
Tianyi - ADS Learning Support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants