Repository navigation
Production - Assignment 1 - #3
mchebotarov wants to merge 3 commits into
Conversation
Production - Assignment 1
Revert "Production - Assignment 1"
efantinatti
left a comment
There was a problem hiding this comment.
Hi @mchebotarov, your commit history contains a complete assignment. The open PR removes those answers; check the comparison direction before merging.
Mark: 12 out of 12, based on completed work at 0bbc772 and 592c675.
Passed — assignment content. PR #3 needs revision before merging.
PR #3: main → assignment-1. Source main is not an assignment-1 variation; the completed branch matches exactly.
One point per criterion.
| Row | Criterion | Completed work | PR #3 head |
|---|---|---|---|
| 7 | Loads environment | 1 | 0 |
| 8 | Imports dask.dataframe | 1 | 1 |
| 9 | Loads environment variable | 1 | 0 |
| 10 | Produces glob | 1 | 0 |
| 11 | Groups features by ticker | 1 | 0 |
| 12 | Calculates returns | 1 | 0 |
| 13 | Calculates high–low range | 1 | 0 |
| 14 | Calculates features through Dask | 1 | 0 |
| 15 | Converts using compute() | 1 | 0 |
| 16 | Adds moving average | 1 | 0 |
| 17 | Groups moving average by ticker | 1 | 0 |
| 18 | Assesses pandas/Dask choice | 1 | 0 |
Commit scan: PR #1’s 9acec91 is incomplete; b71ae1b completes it; 0bbc772 cleans outputs. PR #3’s 592c675 retains completion; 61467b5 reverts it; 81717e9 retains placeholders.
Summary: Completed work: 12 right, 0 wrong; no missing criteria. Current PR head: 1 right, 11 missing. Please review the zero-point rows and comparison direction. Completed calculations passed checks on 75 synthetic observations across three tickers/four files; real course data was unavailable. Check the requested range-column spelling. Only notebook changes; no module readme update needed. File marked Viewed.
Best regards,
@efantinatti
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Adding code
What did you learn from the changes you have made?
How to manipulate test data
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
No
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
Yes. I never used Dask or Pandas before so I had to spend time reading the 10 minute tutorial to understand what I was doing.
How were these changes tested?
Yes, I looked at the test data and made sure the data looked correct
A reference to a related issue in your repository (if applicable)
Checklist