Repository navigation
Production - Assignment 2 - #4
Open
mchebotarov wants to merge 2 commits into
Open
mchebotarov wants to merge 2 commits into
mchebotarov wants to merge 2 commits into
Conversation
added 2 commits
October 16, 2026 14:32
efantinatti
approved these changes
Oct 21, 2026
There was a problem hiding this comment.
Hi @mchebotarov, your modelling code is complete, but the submitted notebook contains no saved outputs. Please revisit the missing execution evidence.
Mark: 15 out of 15
Assignment 2 assessment - mchebotarov PR #4
One point per criterion.
| ID | Score (0-1) | Evidence (cell) | Note |
|---|---|---|---|
| A2-01 | 1 | 9 | Features/target separated |
| A2-02 | 1 | 10 | 80/20 split, seed 42 |
| A2-03 | 1 | 14,16 | Two preprocessors |
| A2-04 | 1 | 14,16 | Month/day categorical |
| A2-05 | 1 | 14,16 | Unseen categories handled |
| A2-06 | 1 | 16,19,21 | Rain squared in B/D |
| A2-07 | 1 | 18-21 | Four pipelines |
| A2-08 | 1 | 18-21 | Ridge and random forest |
| A2-09 | 1 | 31 | Pipeline pickled with context manager |
| A2-10 | 1 | 23-26 | Five-fold validation |
| A2-11 | 1 | 23-26 | MAE error metric |
| A2-12 | 1 | 27,29 | A has optimal CV score |
| A2-13 | 1 | 23-26 | Five candidates per grid |
| A2-14 | 1 | 34-35 | Local/global SHAP plots |
| A2-15 | 1 | 37 | FFMC interpretation and removal test |
Total: 15 / 15 = 1.00
Summary: 15 right, 0 wrong, no missing rubric criteria. Pipeline A achieves the lowest CV MAE, approximately 16.605. Optional: which features drive the selected prediction, and would global explanations change across the complete training set?
Branch: assignment-2 into main, exact match.
Both commits reviewed: dd0ec40 adds preprocessing, 09f1995 completes modelling, tuning, export, and explanations. Only the assignment notebook changed.
Best regards,
@efantinatti
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Adding code
What did you learn from the changes you have made?
how to manipulate , validate, and understand data
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
No.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
Challenges to understand what it wanted and to use different regressors. I had to read the documentation for each to find the best suitable regressor.
How were these changes tested?
Running each cell and see if it looks correct.
A reference to a related issue in your repository (if applicable)
Checklist