feat: support multiple holders for numbered lab keys - #57
Open
dhairyathareja1 wants to merge 3 commits into
Open
dhairyathareja1 wants to merge 3 commits into
dhairyathareja1 wants to merge 3 commits into
Conversation
Member
|
here are few findings to take reference:
I'd Suggest adding
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #52.
Track multiple holders per key without duplicates: k0 is the master key, and further kN keys are created as needed. Commands without a key number use a separate unknown group.
Show all holders together in key queries, with commands to remove or transfer holdings.
Preserve old owner-based records for recovery; numbered-key holders start empty for manual assignment in Slack.
Key-handling commands
k0is the master key. Add any number of numbered keys (k1,k2, etc.). If the key number is unknown, the holder is recordedunder
unknown—it is never assumed to bek0.List holders
bot who has keys— list all recorded keys and their holdersbot who has k1— list holders of a specific key (k0,k1,k2, etc.)bot who has unknown keys— list holders whose key number is unknownAdd a holder
bot i have k1— add yourself as a holder of a numbered keybot @alice has k1— add someone else as a holder of a numbered keybot i have keys— add yourself underunknownbot @alice has keys— add someone underunknownbot @alice has unknown keys— explicitly add someone underunknownYou can use a person’s Slack username or display name instead of
@alice. If the name matches multiple people, make it more specific.Remove yourself
bot i don't have k1— remove yourself from a numbered keybot i don't have unknown keys— remove yourself fromunknownbot i don't have keys— remove yourself from all recorded keysTransfer keys you hold
bot i gave k1 to @alice— transfer one numbered keybot i gave unknown keys to @alice— transfer yourunknownassignmentbot i gave keys to @alice— transfer all your recorded key assignments