Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #493 +/- ##
=======================================
Coverage 54.22% 54.22%
=======================================
Files 1 1
Lines 225 225
=======================================
Hits 122 122
Misses 103 103 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
marcomangano
reviewed
Sep 9, 2026
| # getOrdering). slfunc/slgrad negate fcon/gcon before handing them to SLSQP | ||
| # (since SLSQP expects constraints of the form c(x) >= 0), so the returned | ||
| # multipliers must be negated to match pyOptSparse's constraint sign convention. | ||
| lambdaStar = -w[:m] |
Collaborator
There was a problem hiding this comment.
Should we keep this consistent with the original notation and just flip the sign for testing purposes, like we do for IPOPT here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
SLSQP Lagrange multiplier was broken previously, it is fixed here and turns out to be easier than I thought.
Expected time until merged
Would be nice to sneak into this upcoming release.
Type of change
Testing
Added to existing hs071 test.
Checklist
ruff checkandruff formatto make sure the Python code adheres to PEP-8 and is consistently formattedfprettifyor C/C++ code withclang-formatas applicable