ci(release): rely on the release environment alone (settlers: any)

[Troublor]

Drops settlers: admin from release-settle.yml: the release environment's required reviewers are the release gate, and the extra check that the dispatcher is a repository admin duplicated it. The shared action now defaults settlers to any (megaeth-labs/.github#42), so leaving it unset means "the environment alone". Header comment updated. Merge after megaeth-labs/.github#42; before that, an unset settlers fails direct mode.

🤖 Generated with Claude Code

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-09-09T11:03:11.186541Z	0acc9c1	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[mega-maxwell]

Claude review status

Living comment — rewritten in place. The review workflow keeps this single comment up to date instead of posting a new one each round, so it always describes the latest reviewed commit and the earlier text is intentionally gone. No reply is needed here; reply to a finding in its own review thread, and answer an open question in a reply on this PR. The next review round reconciles your answer.

🛠️ Review did not finish

Attempted 0acc9c16..0acc9c16 · updated 2026-09-09T11:03:35+00:00

This round did not publish: MODEL_ACTION_FAILED in phase review_retry. Anything listed below is from the last round that did. Re-run the workflow or push a new commit to try again.

Open questions awaiting an answer:

• ❓ Has feat(release-settle): settlers: any — rely on the environment; now the default .github#42 (the change that defaults settlers to any in the shared release-settle action) been merged to that repo's main before this PR merges? (asked here)

[github-actions]

🧬 Mutation testing — ✅ PASS

Nothing to test — no mutants were generated on the changed lines.

[github-actions]

🧬 Mutation testing

No results at target/mutants/mutants.out — nothing was mutated (e.g. no mutatable changes).

[mega-maxwell]

❓ Review complete — 1 open question(s)

Reviewed head 0acc9c16.

Removes settlers: admin from release-settle.yml and rewords the header comment so the release environment reviewers are the sole gate.

Open questions — answer them in a reply on this PR. Each one is marked answered here once a later review round confirms the answer, so this list stays current:

❓ **Open question · Low confidence**

• Has megaeth-labs/.github#42 (the change that defaults settlers to any in the shared release-settle action) been merged to that repo's main before this PR merges?
• Why it matters: The workflow pins megaeth-labs/.github/.github/actions/release-settle@main and no longer passes settlers. Per the PR description, until #42 lands on main, an unset settlers fails direct mode, so any release-settle dispatch would break until the shared action catches up.
• How to verify: Confirm megaeth-labs/.github#42 is merged (or coordinate merge order so it lands first), then dispatch this workflow once against a test version to verify the shared action accepts an unset settlers in direct mode.

[Copilot]

🟡 Changes recommended

The workflow now implicitly relies on the shared action’s default settlers behavior; making settlers: any explicit would keep this security-sensitive behavior stable and self-documenting.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Updates the release settlement workflow to rely solely on the release GitHub Environment approvals as the gate for running a settlement, removing the redundant “dispatcher must be admin” check previously enforced via the settlers input to the shared action.

Changes:

• Updates the workflow header comment to describe the environment-only gating model.
• Removes settlers: admin from the release-settle action invocation.

File summaries

File	Description
.github/workflows/release-settle.yml	Removes the extra admin-only gate and documents relying on the release environment for settlement authorization.

Review details

Suppressed comments (1)

.github/workflows/release-settle.yml:63

• To make the authorization behavior stable and self-documenting, set settlers: any explicitly rather than relying on the shared action’s default for this security-sensitive input.

          version_file: Cargo.toml
          version_pattern: toml
          changelog_file: CHANGELOG.md
          settle_mode: direct

• Files reviewed: 1/1 changed files
• Comments generated: 1
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.