Skip to content

ci(release): rely on the release environment alone (settlers: any) - #217

Merged
Troublor merged 1 commit into
mainfrom
troublor/ci/settlers-any
Sep 9, 2026
Merged

ci(release): rely on the release environment alone (settlers: any)#217
Troublor merged 1 commit into
mainfrom
troublor/ci/settlers-any

Conversation

@Troublor

@Troublor Troublor commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Drops settlers: admin from release-settle.yml: the release environment's required reviewers are the release gate, and the extra check that the dispatcher is a repository admin duplicated it. The shared action now defaults settlers to any (megaeth-labs/.github#42), so leaving it unset means "the environment alone". Header comment updated. Merge after megaeth-labs/.github#42; before that, an unset settlers fails direct mode.

🤖 Generated with Claude Code

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 9, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-09T11:00:28.647644Z f6f9b0a PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@mega-maxwell

mega-maxwell Bot commented Sep 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Claude review status

Living comment — rewritten in place. The review workflow keeps this single comment up to date instead of posting a new one each round, so it always describes the latest reviewed commit and the earlier text is intentionally gone. No reply is needed here; reply to a finding in its own review thread, and answer an open question in a reply on this PR. The next review round reconciles your answer.

✅ Review clean

Last reviewed: head f6f9b0a8 · updated 2026-09-09T11:00:44+00:00

New this round: 0 finding(s), 0 question(s) · Resolved this round: 0 · Open questions: 0

@Troublor @claude
ci(release): rely on the release environment alone (settlers: any)
f6f9b0a 
The environment's required reviewers are the release gate; the extra
admin check on the dispatcher duplicated it and is dropped now that the
shared action defaults settlers to any.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@Troublor
Troublor merged commit d14fb44 into main Sep 9, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flyq flyq Awaiting requested review from flyq flyq is a code owner
@yunlonggao-mega yunlonggao-mega Awaiting requested review from yunlonggao-mega yunlonggao-mega is a code owner
@mingy-mega mingy-mega Awaiting requested review from mingy-mega mingy-mega is a code owner
@hongbo-trey hongbo-trey Awaiting requested review from hongbo-trey hongbo-trey is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Troublor