Skip to content

ci(release): accept a base_commit on the release candidate - #218

Merged
Troublor merged 2 commits into
mainfrom
troublor/ci/candidate-base-commit
Sep 11, 2026
Merged

ci(release): accept a base_commit on the release candidate#218
Troublor merged 2 commits into
mainfrom
troublor/ci/candidate-base-commit

Conversation

@Troublor

Copy link
Copy Markdown
Collaborator

release-candidate gained a base_commit input in megaeth-labs/.github, for releasing a commit that is not the tip of the default branch. A workflow_dispatch input has to be declared in each workflow before it can be passed, so without this the feature cannot be dispatched here at all.

Two additions, matching the updated workflow-templates/release-candidate.yml:

  • the base_commit dispatch input, optional and blank by default;
  • passing it through to the propose step.

Blank keeps today's behaviour exactly: the candidate PR goes to the default branch and the cut job creates the release branch at the merge commit. Given a commit, propose cuts release-vX.Y.Z at that commit and aims the candidate PR at it, so the default branch is untouched and cut does not run.

gh workflow run release-candidate.yml -R OWNER/REPO --ref DEFAULT \
  -f version=X.Y.Z -f base_commit=$(git rev-parse origin/DEFAULT~4)

The commit must be reachable from the default branch. Note that v* tags are not, because settlement commits the dated changelog on the release branch. Full guide: megaeth-labs/.github/.github/actions/RELEASE.md, section "Releasing a commit that is not the tip".

actionlint clean.

🤖 Generated with Claude Code

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 11, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-11T08:59:53.707590Z c72b176 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

release-candidate now takes a base_commit, to release a commit that is
not the tip of the default branch. A workflow_dispatch input must be
declared per workflow before it can be passed, so the feature is not
dispatchable here until this lands.

Blank is today's behaviour unchanged.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@mega-maxwell

mega-maxwell Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Claude review status

Living comment — rewritten in place. The review workflow keeps this single comment up to date instead of posting a new one each round, so it always describes the latest reviewed commit and the earlier text is intentionally gone. No reply is needed here; reply to a finding in its own review thread, and answer an open question in a reply on this PR. The next review round reconciles your answer.

✅ Review clean

Last reviewed: c72b1765..02e654da · updated 2026-09-11T09:26:57+00:00

New this round: 0 finding(s), 0 question(s) · Resolved this round: 0 · Open questions: 0

The header still said the cut job always creates the release branch at
the merge commit. With base_commit, propose creates it at the named
commit and cut does not run at all, so an operator reading only the
header would be misled about which branch the candidate PR touches.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@Troublor
Troublor merged commit c6fe663 into main Sep 11, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant