Conversation
Frequency controllers are eagerly populated in serverLoad(), which never runs on a pure remote client. Any client-side call that reaches getController() (e.g. BlockMekanism#setPlacedBy -> ISecurityTile#setOwnerUUID placing a machine while connected to a dedicated server) hit a null controller and crashed with an NPE. createLookup() already had a client-safe, non-persisted fallback for this case (guarded by dataStorage == null), but it was unreachable because getController() returned null before ever reaching it. Lazily create the controller on demand instead, so every call site is covered rather than special-casing individual callers. Fixes mekanism#8590
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Frequency controllers are eagerly populated in serverLoad(), which never runs on a pure remote client. Any client-side call that reaches getController() (e.g. BlockMekanism#setPlacedBy -> ISecurityTile#setOwnerUUID placing a machine while connected to a dedicated server) hit a null controller and crashed with an NPE.
createLookup() already had a client-safe, non-persisted fallback for this case (guarded by dataStorage == null), but it was unreachable because getController() returned null before ever reaching it.
Lazily create the controller on demand instead, so every call site is covered rather than special-casing individual callers.
Fixes #8590
Changes proposed in this pull request: