docs(knowledge): fix youtube-digest contact-sheet retention wording + --target resolution gap#1027
docs(knowledge): fix youtube-digest contact-sheet retention wording + --target resolution gap#1027kyle-sexton wants to merge 1 commit into
Conversation
… --target resolution gap Site 1 (SKILL.md intro): the `key-frames/contact-sheets/` snapshot was bucketed as "temp-only handling," contradicting the Output contract's "local DR snapshot, gitignored" characterization of the same directory. Reworded to "never-committed handling" so the snapshot reads as a durable-on-disk-but-gitignored instance of that handling, not temp state. Site 2 (Synthesis target resolution): `--target <repo>` resolved to a name only, but `templates/synthesis-item.md`'s grep-backed Target touchpoints need a tree to grep. Resolution now requires a local working tree on disk; an explicit `--target` with no local checkout halts and asks for its path instead of falling through to CLAUDE_PROJECT_DIR/CWD or inventing paths. Both the target name and its resolved local tree path are recorded in the README Target line so `resume` re-greps the same tree. Knowledge plugin 0.9.2 -> 0.9.3 + CHANGELOG entry. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Mu8bLN896ia5AeWmGPqAUv
|
Claude finished @kyle-sexton's task in 1m 34s —— View job PR Review
SummaryTwo well-scoped doc/behavior-contract fixes in Site 1 — Contact-sheet retention wordingThe swap of Site 2 —
|
|
Claude finished @kyle-sexton's task in 1m 8s —— View job Security Review — PR #1027
No security issues found. All four changed files are documentation / plain-text artifacts:
SKILL.md line 289 ( The template update ( Scope checked: no GitHub Actions changes, no new shell commands, no dependency changes, no credential/secret handling, no external service calls. |
|
🔒 merge-drive lane claiming this PR for on-branch fix work this cycle (amendment-round: 16, worker tier). Will fix clear branch-owned CI/bot findings, defer non-DEFER-FORBIDDEN items with reply+resolve, push, then re-check the merge gate. |
Summary
Two deferred codex-P2 follow-ups from the 2026-07-21 babysit verifier session on merged PR #854, both confined to
plugins/knowledge/skills/youtube-digest/. Documentation / behavior-contract fixes; no open design fork.Fix
Site 1 — contact-sheet retention wording (
SKILL.md, intro paragraph).The line called the
key-frames/contact-sheets/snapshot "temp-only handling," which contradicts the Output contract's characterization of the same directory (key-frames/contact-sheets/*.jpg→ "local DR snapshot, gitignored"). RewordedThat temp-only handling is otherwise a fixed…→That never-committed handling is a fixed…. The snapshot now reads as a durable-on-disk-but-gitignored instance of never-committed handling, not an exception to a temp-only rule — consistent with the same paragraph's own "durable on disk (it survivestempSessioncleanup)" and with the Output contract.Site 2 —
--targetlocal-checkout resolution gap (SKILL.md, "Synthesis target resolution").--target <repo>resolved to a target name only, buttemplates/synthesis-item.md's Target touchpoints field is grep-backed and needs a real tree. Awatch --target <repo>from a separate corpus session (where the named repo isn't checked out) had no tree to grep and could fall through toCLAUDE_PROJECT_DIR/CWD or invent paths. Fixed by:--targetcase: no local checkout → halt and ask for the local checkout path, never fall through toCLAUDE_PROJECT_DIR, grep CWD, or invent touchpoint paths. (Auto-clone is left to the future/knowledge:applydesign, which is unbuilt; "resolve-or-halt" fully satisfies the acceptance without new clone infra.)README.md's**Target:**line (templates/readme-journey.mdupdated to match) soresumere-greps the same tree instead of re-inferring it — closing the resume-durability side of the finding.Knowledge plugin
0.9.2→0.9.3+ top-insertedCHANGELOG.mdentry.Verification
Site 1 — the umbrella term now matches the Output contract; the file no longer buckets the snapshot as temp-only:
Site 2 — resolution now names a local tree and a loud-fail path;
synthesis-item.md's grep-backed field has a tree to grep, and the recorded Target line carries the path forresume:markdownlint-cli2on all three changed markdown files → 0 errors.G) per the org ruleset.Closes #1015
Related
🤖 Generated with Claude Code
https://claude.ai/code/session_01Mu8bLN896ia5AeWmGPqAUv
Work-class: C3 (bug-fix-shaped) — attended triage 2026-07-23, operator-ratified. 🤖