Skip to content

docs(disk-hygiene): --execute manual-lane contract, hint-prose trust boundary, doc polish (F7/F9/F10)#1148

Merged
kyle-sexton merged 2 commits into
mainfrom
docs/1113-dh-doc-batch
Jul 23, 2026
Merged

docs(disk-hygiene): --execute manual-lane contract, hint-prose trust boundary, doc polish (F7/F9/F10)#1148
kyle-sexton merged 2 commits into
mainfrom
docs/1113-dh-doc-batch

Conversation

@kyle-sexton

Copy link
Copy Markdown
Contributor

Summary

dh 0.8.1 — the consumer-audit declarative/doc batch (findings F7, F9, F10). Docs-only; no engine or guard code changes.

  • F7 — --execute contract for the manual lane (decision recorded, not silently resolved). The flag now explicitly gates every deletion lane: the gated engine lane where supported, the manual handoff elsewhere. This is named in the doc as a deliberate semantic unification — the flag previously read as "offer the gated ENGINE lane" (which can never apply on Windows/macOS), leaving the manual lane's gate ambiguous; the audit observed consumer sessions reading it both ways, including one that proceeded to manual deletion without --execute. The issue's adversarial-review comment asked that the semantic shift be named rather than passed off as clarification — done at the argument definition and in the manual-handoff precondition (lane symmetry, per the issue's recommendation).
  • F9 — hint-prose trust boundary. Safety-model trust boundaries now name standing-policy additional_hints[].reason prose as untrusted claims requiring independent evidence: additive-only design means hints can't authorize anything, but the prose reached triage reasoning unlabeled.
  • F10(a). Setup SKILL.md + README corrected: preview reports execution-platform-unsupported as a per-candidate blocker, not a top-level status — verified against preview()'s payload shape (blockers live in candidates[].blockers; top-level status is blocked/ready-for-explicit-approval).
  • F10(b). README states once that the Recycle-Bin / Trash naming is a model-layer distinction only; the engine treats Windows and macOS identically (execution unsupported).
  • F10(c) — DECLINED with evidence. The hub-restructure suggestion rested on an MD013 line-length complaint; the repo's .markdownlint-cli2.jsonc sets "MD013": false ("No hard line-length limit"), so the complaint came from an out-of-repo lint run, and the skill-quality gate passes the hub at its current length.

Scheduling note: #1113 was queued behind draft PR #1124 (file overlap on setup SKILL.md / README / CHANGELOG). That draft has been stale for ~4h with CI green; the actual hunk overlap is disjoint (different sections), so this batch proceeds — whichever merges second rebases trivially (CHANGELOG entry ordering + version bump).

Test plan

  • check-changelog-parity.sh --check-bump origin/main → pass (0.8.1 + entry)
  • check-changed-skills.sh → 2 skills checked, 0 failed
  • Docs-only: no engine tests affected (suite untouched)
  • CI green

Related

Closes #1113. Source: handoff-inbox item 20260723-021058-disk-hygiene-0-6-4-consumer-audit, findings F7/F9/F10. F7 decision context: the adversarial-review comment on #1113.

🤖 Generated with Claude Code

…boundary, doc polish (F7/F9/F10)

dh 0.8.1 — closes #1113, the consumer-audit doc batch:

- F7: --execute now explicitly gates every deletion lane, including the
  manual handoff. Named as a deliberate semantic unification (the flag
  previously read engine-lane-only, leaving the manual lane's gate
  ambiguous; consumer sessions read it both ways). Stated at the argument
  definition and in the manual-handoff precondition.
- F9: safety-model trust boundaries name standing-policy
  additional_hints[].reason prose as untrusted claims requiring
  independent evidence.
- F10a: setup SKILL.md + README corrected — preview reports
  execution-platform-unsupported as a per-candidate blocker, not a
  top-level status (verified against preview()'s payload shape).
- F10b: README states once that Recycle-Bin/Trash naming is model-layer
  only; the engine treats Windows and macOS identically.
- F10c: hub restructure DECLINED with evidence: repo markdownlint config
  sets MD013 false (no line-length rule; complaint came from an
  out-of-repo run) and the skill-quality gate passes the hub as-is.

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
@claude

claude Bot commented Jul 23, 2026

Copy link
Copy Markdown

Claude encountered an error after 1s —— View job


I'll analyze this and get back to you.

@claude

claude Bot commented Jul 23, 2026

Copy link
Copy Markdown

Claude encountered an error after 1s —— View job


I'll analyze this and get back to you.

@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown

Warning

Automated security review did not complete — this is an infrastructure failure, not a review verdict.

Treat any Claude comment on this PR (including a placeholder like "I'll analyze this and get back to you") as incomplete, not "no findings."

Re-running the job, or pushing a new commit, will retry the review.

@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown

Warning

Automated review did not complete — this is an infrastructure failure, not a review verdict.

Treat any Claude comment on this PR (including a placeholder like "I'll analyze this and get back to you") as incomplete, not "no findings."

Re-running the job, or pushing a new commit, will retry the review.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b9d97f25e1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread plugins/disk-hygiene/README.md Outdated
…tup posture lanes

Codex review P2: the README's Windows bullet and the setup skill's
Windows/macOS posture lines still described the manual handoff as gated by
explicit approval alone, contradicting the just-unified contract that no
deletion lane may be offered without --execute. All three spots now name
the flag prerequisite.

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
@claude

claude Bot commented Jul 23, 2026

Copy link
Copy Markdown

Claude encountered an error after 1s —— View job


I'll analyze this and get back to you.

@claude

claude Bot commented Jul 23, 2026

Copy link
Copy Markdown

Claude encountered an error after 0s —— View job


I'll analyze this and get back to you.

@kyle-sexton
kyle-sexton merged commit 2733f91 into main Jul 23, 2026
25 checks passed
@kyle-sexton
kyle-sexton deleted the docs/1113-dh-doc-batch branch July 23, 2026 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs(disk-hygiene): --execute manual-lane contract, hint-prose trust boundary, doc polish (F7/F9/F10)

1 participant