docs(disk-hygiene): --execute manual-lane contract, hint-prose trust boundary, doc polish (F7/F9/F10)#1148
Conversation
…boundary, doc polish (F7/F9/F10) dh 0.8.1 — closes #1113, the consumer-audit doc batch: - F7: --execute now explicitly gates every deletion lane, including the manual handoff. Named as a deliberate semantic unification (the flag previously read engine-lane-only, leaving the manual lane's gate ambiguous; consumer sessions read it both ways). Stated at the argument definition and in the manual-handoff precondition. - F9: safety-model trust boundaries name standing-policy additional_hints[].reason prose as untrusted claims requiring independent evidence. - F10a: setup SKILL.md + README corrected — preview reports execution-platform-unsupported as a per-candidate blocker, not a top-level status (verified against preview()'s payload shape). - F10b: README states once that Recycle-Bin/Trash naming is model-layer only; the engine treats Windows and macOS identically. - F10c: hub restructure DECLINED with evidence: repo markdownlint config sets MD013 false (no line-length rule; complaint came from an out-of-repo run) and the skill-quality gate passes the hub as-is. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
|
Claude encountered an error after 1s —— View job I'll analyze this and get back to you. |
|
Claude encountered an error after 1s —— View job I'll analyze this and get back to you. |
|
Warning Automated security review did not complete — this is an infrastructure failure, not a review verdict. Treat any Claude comment on this PR (including a placeholder like "I'll analyze this and get back to you") as incomplete, not "no findings."
Re-running the job, or pushing a new commit, will retry the review. |
|
Warning Automated review did not complete — this is an infrastructure failure, not a review verdict. Treat any Claude comment on this PR (including a placeholder like "I'll analyze this and get back to you") as incomplete, not "no findings."
Re-running the job, or pushing a new commit, will retry the review. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b9d97f25e1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…tup posture lanes Codex review P2: the README's Windows bullet and the setup skill's Windows/macOS posture lines still described the manual handoff as gated by explicit approval alone, contradicting the just-unified contract that no deletion lane may be offered without --execute. All three spots now name the flag prerequisite. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
|
Claude encountered an error after 1s —— View job I'll analyze this and get back to you. |
|
Claude encountered an error after 0s —— View job I'll analyze this and get back to you. |
Summary
dh 0.8.1 — the consumer-audit declarative/doc batch (findings F7, F9, F10). Docs-only; no engine or guard code changes.
--executecontract for the manual lane (decision recorded, not silently resolved). The flag now explicitly gates every deletion lane: the gated engine lane where supported, the manual handoff elsewhere. This is named in the doc as a deliberate semantic unification — the flag previously read as "offer the gated ENGINE lane" (which can never apply on Windows/macOS), leaving the manual lane's gate ambiguous; the audit observed consumer sessions reading it both ways, including one that proceeded to manual deletion without--execute. The issue's adversarial-review comment asked that the semantic shift be named rather than passed off as clarification — done at the argument definition and in the manual-handoff precondition (lane symmetry, per the issue's recommendation).additional_hints[].reasonprose as untrusted claims requiring independent evidence: additive-only design means hints can't authorize anything, but the prose reached triage reasoning unlabeled.previewreportsexecution-platform-unsupportedas a per-candidate blocker, not a top-level status — verified againstpreview()'s payload shape (blockers live incandidates[].blockers; top-level status isblocked/ready-for-explicit-approval)..markdownlint-cli2.jsoncsets"MD013": false("No hard line-length limit"), so the complaint came from an out-of-repo lint run, and the skill-quality gate passes the hub at its current length.Scheduling note: #1113 was queued behind draft PR #1124 (file overlap on setup SKILL.md / README / CHANGELOG). That draft has been stale for ~4h with CI green; the actual hunk overlap is disjoint (different sections), so this batch proceeds — whichever merges second rebases trivially (CHANGELOG entry ordering + version bump).
Test plan
check-changelog-parity.sh --check-bump origin/main→ pass (0.8.1 + entry)check-changed-skills.sh→ 2 skills checked, 0 failedRelated
Closes #1113. Source: handoff-inbox item
20260723-021058-disk-hygiene-0-6-4-consumer-audit, findings F7/F9/F10. F7 decision context: the adversarial-review comment on #1113.🤖 Generated with Claude Code