docs(source-control): point babysit-prs cadence cross-references at loop.md §5.3#1307
Conversation
…oop.md §5.3 (#653) Closes #653 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NE8W4XPPVfZVCGBW2GYgyH
…skill line cap (#653) Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NE8W4XPPVfZVCGBW2GYgyH
… the cadence drift (#653) Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NE8W4XPPVfZVCGBW2GYgyH
|
Claude finished @kyle-sexton's task in 1m 54s —— View job PR Review
Verdict: Approve. All factual claims in the PR description check out against the files on this branch. The fix is correct, appropriately scoped, and internally consistent. Verified claims
Step-5 trigger changeThe wording shift from "recommending cadence" to "interpreting a cadence state" is semantically correct: Step-9 pointer consolidationDropping the direct Wrong-number risk in the Reporting lineThe PR description's description of the live risk is accurate. A model following the old instruction ("Recommend the exact next interval per CHANGELOG and version bump
Version conflict noteThe PR correctly flags that PRs #1285 and #1264 both claim No issues found. The change is clean, the reasoning holds, and the files are consistent. |
|
Claude finished @kyle-sexton's task in 55s —— View job Security Review — No findings
Scope: This PR is documentation-only. Working through each attack surface in scope:
No security issues found. |
This was generated by AI during an autonomous work-loop execution session.
Closes #653
Summary
babysit-prs's SKILL.md described a cadence-ownership split that no longer exists.#652 added the engine-backed
recommended_cadence→ScheduleWakeup.delaySecondsmapping table toreference/loop.md§5.3, alongside the static Python-free degrade ladder already living there.reference/cadence.mdowns only the cadence states and thresholds — and has said so since #322("
loop.mdowns the wake mechanics, this file owns the states and thresholds behind therecommendation"). SKILL.md still routed readers the old way:
recommended_cadencepercadence.md;loop.md§5.3 named only as the "static ladder … Python-free degrade"Schedule the next wake per the cadence contract in reference/loop.md §5.3.cadence.md"loop.md§5.3loop.mdcadence.md"only before recommending cadence"cadence.md"only before interpreting a cadence state"The filed issue named step 9. The other three are the same defect: leaving them would have made the
file internally inconsistent about which section owns the seconds.
The Reporting line was a live wrong-number risk, not just imprecision.
cadence.mdstatesidle= daily; §5.3 documentsScheduleWakeupclampingdelaySecondsto[60, 3600], soinside
/loopidleandquietboth wake hourly. "Recommend the exact next interval percadence.md" could therefore surface an interval the loop will never schedule.The
cadence.mdlink is dropped from step 9 rather than kept alongsideloop.md: §5.3 alreadyhops to
cadence.mdfor the states in one line, so a second pointer here is the gratuitouscross-reference
CLAUDE.md's pointer-not-copy rule forbids.cadence.mdkeeps its own Referencesentry and its step-5 disclosure trigger. The new step-9 wording matches vocabulary the file already
uses at its Step 7 checklist line ("schedule the next wake per the cadence contract (§5.3)") and in
the sibling
babysit-loopSKILL.md ("that mapping owns the seconds").Docs-only. No behavior change, no script or engine change.
source-control0.26.1→0.26.2with the matching CHANGELOG entry.
Test plan
Every command below was run from the branch worktree; all passed.
plugins/skill-quality/scripts/check-skill.sh babysit-prs(CHECK_SKILL_BASE_REF=origin/main) —exit 0,
PASS — 0 errors. This is the gate CI runs viascripts/check-changed-skills.sh.Includes the 500-line hard cap, all 9 base-ref trigger phrases preserved, broken-internal-ref
check, and
scripts/engine.test.sh.origin/main: 499). An intermediate revision of this branchlanded at exactly 500 and failed the hard cap (
LINE_COUNT >= LINE_HARD_CAP, cap 500) — caughtby an independent reviewer before the PR was opened. Collapsing step 9 to a single pointer and the
References bullet back to two lines both fixed the cap and made the diff better follow
pointer-not-copy. The one remaining
WARNis the pre-existing 200-line soft target, untouched bythis change.
scripts/check-changelog-parity.sh --check— exit 0.scripts/check-changelog-parity.sh --check-bump origin/main— exit 0 (the manifest bump has amatching
## [0.26.2]entry).markdownlint-cli2over both changed markdown files, repo config auto-discovered — exit 0,0 errors.
jq emptyonplugins/source-control/.claude-plugin/plugin.json— exit 0.typosover both changed markdown files — exit 0.reference/loop.md,cadence.md,safety.md,orchestration.md,freshness.md,stuck-checks.md,feedback.md,review-trigger.md); the§5.3anchor exists atreference/loop.md:426. No external URLsintroduced, so lychee's absence changes nothing.
grepfor any remaining reference sending a reader tocadence.mdfor wake seconds, ordescribing §5.3 as holding only the static ladder — none remain. The four surviving
cadence.mdcitations in
plugins/source-control/were each checked and are correct.Claims verified against the actual files rather than the issue text: §5.3 does contain both the
mapping table (
loop.md:435-440) and the degrade ladder (loop.md:456-462);cadence.md:4-5doesdisclaim the wake mechanics;
cadence.md:27does stateidle= daily againstloop.md:449-452's[60, 3600]clamp. The CHANGELOG entry's causal account was corrected aftergit show --stat e9cef6e1showed #652 never touchedcadence.md, andgit log -L4,5dated that file's disclaimer tofe78acb6(#322) — so the references were always imprecise; #652 only made the correct targetconcrete.
Per this repo's fresh-docs mandate, https://code.claude.com/docs/en/skills was fetched this
session. It confirms the progressive-disclosure model this diff operates on — SKILL.md body plus
bundled supporting files loaded on demand — and imposes no constraint on how a SKILL.md cites its
own
reference/files, so the choice of pointer is a repo-convention question, decided above byCLAUDE.md's pointer-not-copy rule.Related
reference/cadence.mdfirst disclaimed ownership of the wake mechanics.source-control0.27.0. If either mergesfirst this branch's
0.26.2becomes a regression — it self-surfaces as a git conflict on both themanifest line and the CHANGELOG insert point, so rebase rather than force-merge.
🤖 Generated with Claude Code