Skip to content

Fix/profile multi lang - #16

Merged
sanshuiyijing merged 4 commits into
mainfrom
fix/profile-multi-lang
Aug 25, 2026
Merged

sanshuiyijing merged 4 commits into
mainfrom
fix/profile-multi-lang

Conversation

@sanshuiyijing

Copy link
Copy Markdown
Collaborator

support japanese

@sanshuiyijing
sanshuiyijing force-pushed the fix/profile-multi-lang branch from 9f68ecf to 7e7e4ed Compare August 25, 2026 07:22

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

candidates.set(key, {
title,
summary: this.extractSummary(memory),

P2 Badge Localize source-derived item summaries

For mixed-language profiles, unsynthesized candidates still copy the source memory into items[].summary verbatim. In particular, current_priority never has synthesized candidates, so a Chinese priority in an otherwise English-dominant profile remains Chinese even though the endpoint now promises generated item summaries in the dominant language and reserves original text for evidence quotes.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/api/src/user-profile.service.ts Outdated
@sanshuiyijing
sanshuiyijing merged commit 2889cdf into main Aug 25, 2026
1 check passed
@sanshuiyijing
sanshuiyijing deleted the fix/profile-multi-lang branch August 25, 2026 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant