Repository navigation
Allocate RTMP sink packets with av_new_packet - #131
Merged
Merged
Conversation
Packets were built with av_packet_from_data on an av_malloc buffer without AV_INPUT_BUFFER_PADDING_SIZE, which the API requires and which the FLV muxer's auto-inserted bitstream filters read past. av_new_packet adds the padding and checks the allocation, which was also unchecked before the first memcpy.
varsill
approved these changes
Nov 6, 2026
varsill
left a comment
Contributor
There was a problem hiding this comment.
thanks for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found with Claude. If it is not useful, kill it. Posted with permission from mat_hek.
Packets were built with av_packet_from_data on an av_malloc buffer without AV_INPUT_BUFFER_PADDING_SIZE, which the API requires and which the FLV muxer's auto-inserted bitstream filters read past. av_new_packet adds the padding and checks the allocation, which was also unchecked before the first memcpy.