Skip to content

Allocate RTMP sink packets with av_new_packet - #131

Merged
varsill merged 1 commit into
membraneframework:masterfrom
lawik:fix/sink-packet-padding
Nov 9, 2026
Merged

varsill merged 1 commit into
membraneframework:masterfrom
lawik:fix/sink-packet-padding

Conversation

@lawik

@lawik lawik commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

Found with Claude. If it is not useful, kill it. Posted with permission from mat_hek.

Packets were built with av_packet_from_data on an av_malloc buffer without AV_INPUT_BUFFER_PADDING_SIZE, which the API requires and which the FLV muxer's auto-inserted bitstream filters read past. av_new_packet adds the padding and checks the allocation, which was also unchecked before the first memcpy.

Packets were built with av_packet_from_data on an av_malloc buffer without
AV_INPUT_BUFFER_PADDING_SIZE, which the API requires and which the FLV
muxer's auto-inserted bitstream filters read past. av_new_packet adds the
padding and checks the allocation, which was also unchecked before the
first memcpy.
@lawik
lawik requested a review from varsill as a code owner October 27, 2026 22:05

@varsill varsill left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contribution!

@varsill
varsill merged commit 570bccc into membraneframework:master Nov 9, 2026
5 checks passed
@varsill varsill self-assigned this Nov 12, 2026
@varsill varsill added this to Smackore Nov 12, 2026
@github-project-automation github-project-automation Bot moved this to Done in Smackore Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants