Repository navigation
Conversation
flush_and_close_stream freed output_ctx but left the pointer set, so any later NIF call used freed memory. write_*_frame before try_connect or before the header was written handed the FLV muxer a NULL pb. NULL the context after freeing and return an error from every entry point in those states.
Contributor
|
Hello! We already handle it partially within #134 so I will close this PR and implement the missing parts there. I will then release a new version of the plugin. Thanks for bringing this up! |
varsill
added a commit
that referenced
this pull request
Nov 9, 2026
Return an error from every NIF entry point once the output context is freed, refuse to write frames before the FLV header exists, and raise instead of handing FFmpeg a NULL connection when the header or trailer would be written before try_connect. Based on #132.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found with Claude. If it is not useful, kill it. Posted with permission from mat_hek.
flush_and_close_stream freed output_ctx but left the pointer set, so any later NIF call used freed memory. write_*_frame before try_connect or before the header was written handed the FLV muxer a NULL pb. NULL the context after freeing and return an error from every entry point in those states.