feat: add env var for additional trusted proxy IPs/subnets#101
Merged
Conversation
eleboucher
pushed a commit
to eleboucher/homelab
that referenced
this pull request
Jun 14, 2026
…41) (#1092) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/mendhak/http-https-echo](https://github.com/mendhak/docker-http-https-echo) | major | `40` → `41` | --- ### Release Notes <details> <summary>mendhak/docker-http-https-echo (ghcr.io/mendhak/http-https-echo)</summary> ### [`v41`](https://github.com/mendhak/docker-http-https-echo/blob/HEAD/CHANGELOG.md#Version-41---2026-06-14) [Compare Source](mendhak/docker-http-https-echo@40...41) - Added support for additional trusted proxies via `ADDITIONAL_TRUSTED_PROXIES` by [JackMyers001](mendhak/docker-http-https-echo#101) - Express update includes the new way of catching all paths </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xMDEuMSIsInVwZGF0ZWRJblZlciI6IjQzLjEwMS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9jb250YWluZXIiLCJ0eXBlL21ham9yIl19--> Reviewed-on: https://git.erwanleboucher.dev/eleboucher/homelab/pulls/1092
doonga
pushed a commit
to greyrock-labs/home-ops
that referenced
this pull request
Jun 15, 2026
…41) (#284) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/mendhak/http-https-echo](https://github.com/mendhak/docker-http-https-echo) | major | `40` → `41` | --- ### Release Notes <details> <summary>mendhak/docker-http-https-echo (ghcr.io/mendhak/http-https-echo)</summary> ### [`v41`](https://github.com/mendhak/docker-http-https-echo/blob/HEAD/CHANGELOG.md#Version-41---2026-06-14) [Compare Source](mendhak/docker-http-https-echo@40...41) - Added support for additional trusted proxies via `ADDITIONAL_TRUSTED_PROXIES` by [JackMyers001](mendhak/docker-http-https-echo#101) - Express update includes the new way of catching all paths </details> --- ### Configuration 📅 **Schedule**: (in timezone America/New_York) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4yMTQuNiIsInVwZGF0ZWRJblZlciI6IjQzLjIxNC42IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9jb250YWluZXIiLCJ0eXBlL21ham9yIl19--> Reviewed-on: https://git.greyrock.io/greyrock-labs/home-ops/pulls/284
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Express currently trusts forwarded proxy headers from loopback, link-local, and private IP ranges. This works for most deployments, but not for environments where the upstream proxy uses a public IP address.
One example of this is when the proxy has a GUA (Global Unicast Address i.e. public) IPv6 address. In that case, Express will not trust the forwarded headers from the proxy, meaning we will return the IPv6 address of the proxy, rather than the true source IP.
This PR adds
ADDITIONAL_TRUSTED_PROXIES, which accepts one IP address/subnet or a comma-separated list of IP addresses/subnets to append to Express' existingtrust proxyconfiguration. Express will handle the validation of these addresses/subnets, so no additional parsing is needed on our side.