About's image fills the dialog on a Retina screen (#333) - #346
Merged
Merged
Conversation
…ina (#333) ReportCellSize replies in points plus a scale factor; we dropped the scale and drew sixels at half size in each direction on a 2.0 display. Multiply by it, clamped to 1-4, defaulting to 1 when older iTerm2s omit it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
4 tasks
Contributor
|
That works as long as I don't move the terminal between a retina and a non-retina screen.
Is there any way of detecting the monitor at the time the about dialog is opened (rather than at app startup)? |
Moving the window between a Retina and a non-Retina screen changes how many pixels a cell is, so a size measured at startup drew the image too big or too small afterwards. Sixel support still comes from DA1 once at startup. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Yes. Sixel support is still detected once at startup, but the cell size is now measured every time About opens, so it matches the screen the window is on at that moment. You'll see the spinner for a moment while the terminal answers. Moving the window while About is already open won't resize it. Close it and reopen it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a Retina screen in iTerm2, About (
tui) now draws its artwork filling the space reserved for it, instead of a quarter-size image with a blank band beneath. Non-Retina iTerm2 and other sixel terminals are unchanged.iTerm2's
ReportCellSizereply carries a scale factor after the cell's size in points; we now multiply by it. A scale outside 1–4 is clamped, and a missing or unreadable one counts as 1.Closes #333
a-team try tuicode 346