Repository navigation
Fix four worker review findings from #14 - #39
Closed
Aspirant200715 wants to merge 2 commits into
Closed
Aspirant200715 wants to merge 2 commits into
Aspirant200715 wants to merge 2 commits into
Conversation
- sandbox: bound the wait on a stuck exec stream after a timeout kill - workspace: cap the nested .git scan and fail closed over the cap - models: truncation marker names the cap actually applied - tools, phi: SandboxError is one failed step / an inconclusive phi
_find_name kept every directory it found open until the scan ended, so a checkout with about a thousand directories ran out of descriptors under the usual 1024 soft limit. With the fail-closed handling in this PR, every git step on such a checkout (diff, changed paths, the Phi path check) was then refused. The scan now keeps only the directories on the current path open.
OfficialAbhinavSingh
approved these changes
Oct 31, 2026
OfficialAbhinavSingh
left a comment
OfficialAbhinavSingh
left a comment
Member
There was a problem hiding this comment.
checked on the branch and merged with main, everything passes. the daemon thread swap and failing closed at the scan cap both look right.
one thing i pushed a fix for: _find_name kept an fd open for every directory until the scan ended, so under a 1024 soft limit a checkout with ~1000 dirs hit EMFILE, and with this PR that turns into every git step being refused. it now only keeps the current path open, test included.
small nit: spec/receipt-v0.md still says the marker is always 1048576, and _walk has the same fd pattern, can do that as a follow-up.
Member
|
Superseded by #41, which contains this and fixes _walk. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #31
What changed
What I verified
Not verified