Skip to content

nanobind: use system include type for tsl-robin-map - #2967

Open
stephanlachnit wants to merge 1 commit into
mesonbuild:masterfrom
stephanlachnit:p-nanobind
Open

stephanlachnit wants to merge 1 commit into
mesonbuild:masterfrom
stephanlachnit:p-nanobind

Conversation

@stephanlachnit

Copy link
Copy Markdown
Collaborator

Produces some noise for end users unrelated to their project:

In file included from ../subprojects/robin-map-1.4.1/include/tsl/robin_hash.h:43,
                 from ../subprojects/robin-map-1.4.1/include/tsl/robin_map.h:34,
                 from ../subprojects/nanobind-3.1.0/src/nb_internals.h:15,
                 from ../subprojects/nanobind-3.1.0/src/nb_internals.cpp:12,
                 from ../subprojects/nanobind-3.1.0/src/nb_combined.cpp:78:
../subprojects/robin-map-1.4.1/include/tsl/robin_growth_policy.h: In constructor ‘tsl::rh::power_of_two_growth_policy<GrowthFactor>::power_of_two_growth_policy(std::size_t&) [with long unsigned int GrowthFactor = 2]’:
../subprojects/robin-map-1.4.1/include/tsl/robin_growth_policy.h:106:51: warning: ‘<unknown>’ may be used uninitialized [-Wmaybe-uninitialized]
  106 |     if (min_bucket_count_in_out > max_bucket_count()) {
      |                                   ~~~~~~~~~~~~~~~~^~
../subprojects/robin-map-1.4.1/include/tsl/robin_growth_policy.h:143:15: note: by argument 1 of type ‘const tsl::rh::power_of_two_growth_policy<2>*’ to ‘std::size_t tsl::rh::power_of_two_growth_policy<GrowthFactor>::max_bucket_count() const [with long unsigned int GrowthFactor = 2]’ declared here
  143 |   std::size_t max_bucket_count() const {
      |               ^~~~~~~~~~~~~~~~

Since this is fully within tsl-robin-map I don't think this should be spit out for every nanobind file.

Upstream fix is Tessil/robin-map#96 and mostly cosmetic.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant