Cut the nightly branch in this repo instead of from test-infra - #1554
Merged
Merged
Conversation
Our nightly branch is cut by pytorch/test-infra's trigger_nightly.yml, which runs .github/actions/trigger-nightly as pytorchbot. On 2026-09-10 pytorchbot stopped being able to write to the meta-pytorch org: in that day's run all six pytorch/* domains cut fine and all eight resolving to meta-pytorch/* failed with git exit 128. Our nightly branch has not moved since 2026-09-09T11:37:02Z and no wheels have been built since. Move the cut here, where GITHUB_TOKEN already has the access. cut-nightly runs the same commit-tree/force-push as the test-infra action, so the nightly branch keeps being a real branch carrying main's tree under a dated commit -- unchanged for anything that consumes it. A push made with GITHUB_TOKEN does not start a new workflow run, so the existing `push: branches: [nightly]` trigger cannot be what builds this. The build therefore runs in the same run as the cut, with ref: nightly so it builds exactly the commit just pushed. That trigger stays for manual pushes to the branch. trigger-event is already github.event_name, and test-infra's _binary_upload.yml treats `schedule` as a first-class nightly path -- same pytorchbot-env, same gha_workflow_nightly_build_wheels OIDC role, same upload gate as a refs/heads/nightly push -- so the upload side needs no change. The matrix has said meta-pytorch/data since 202573b and uploaded under that OIDC sub daily through 2026-09-09, so the role trust is already correct. generate-matrix and build gain `if: !failure() && !cancelled()` because cut-nightly is skipped on every event except schedule, and a skipped `needs` would otherwise skip them too. The commit is attributed to github-actions[bot] rather than pytorchbot, since that is now who makes it.
meta-cla
Bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our nightly branch is cut by pytorch/test-infra's trigger_nightly.yml, which runs .github/actions/trigger-nightly as pytorchbot. On 2026-09-10 pytorchbot stopped being able to write to the meta-pytorch org: in that day's run all six pytorch/* domains cut fine and all eight resolving to meta-pytorch/* failed with git exit 128. Our nightly branch has not moved since 2026-09-09T11:37:02Z and no wheels have been built since.
Move the cut here, where GITHUB_TOKEN already has the access. cut-nightly runs the same commit-tree/force-push as the test-infra action, so the nightly branch keeps being a real branch carrying main's tree under a dated commit -- unchanged for anything that consumes it.
A push made with GITHUB_TOKEN does not start a new workflow run, so the existing
push: branches: [nightly]trigger cannot be what builds this. The build therefore runs in the same run as the cut, with ref: nightly so it builds exactly the commit just pushed. That trigger stays for manual pushes to the branch.trigger-event is already github.event_name, and test-infra's _binary_upload.yml treats
scheduleas a first-class nightly path -- same pytorchbot-env, same gha_workflow_nightly_build_wheels OIDC role, same upload gate as a refs/heads/nightly push -- so the upload side needs no change. The matrix has said meta-pytorch/data since 202573b and uploaded under that OIDC sub daily through 2026-09-09, so the role trust is already correct.generate-matrix and build gain
if: !failure() && !cancelled()because cut-nightly is skipped on every event except schedule, and a skippedneedswould otherwise skip them too.