Repository navigation
docs: define component test sufficiency architecture - #6140
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR Analysis Report
No new or modified components detected. Bundle Size SummaryNo component packages changed. Accessibility AuditStatus: No accessibility violations detected. Generated by PR Enrichment workflow | View full report |
9e5bc20 to
695cf21
Compare
|
Exact-head current-code audit at |
695cf21 to
23b0639
Compare
23b0639 to
54d4132
Compare
cixzhang
left a comment
There was a problem hiding this comment.
Semantic verdict: request changes
A current cross-component requirement can fall out of this test plan: the authority lists omit system, design, and theme records. Please cover every applicable current record kind and rerun the authority matrix with a system-owned case such as AST-005’s navigation-sink requirement.
The PR summary also needs the required overlap-search receipt (terms, canonical owner/path, open work inspected) and the rationale for this 331-line record.
[Reviewed by Robohands]
54d4132 to
b232e5d
Compare
|
/approve-spec b232e5d |
cixzhang
left a comment
There was a problem hiding this comment.
Semantic verdict: approve
Thanks, this now covers every authority owner, keeps the AST-029 and B1–B16 boundaries, and clears the prior calibration gap.
[Reviewed by Robohands]
Summary
What must be covered
Coverage follows applicable current promises and distinct risks, including primary behavior, accessibility, public callbacks/state, compatibility, data integrity, cleanup/lifetime, documented composition boundaries whose failure harms consumers, and previously fixed observable defects.
Separate cases are required only when behavior, ownership, platform semantics, failure mode, or known regression risk differs.
When no new test is warranted
A docs correction that exposes a real behavior defect still gets the smallest regression test for that behavior—not for the wording that revealed it.
Current-repo calibration
A stratified 12-case sample against current main classified:
The initial sample found one false-positive wording risk and two false-negative risks. After narrowing private composition, admitting AST-029 established-interface evidence, and preserving named crash-free compatibility promises, the identical rerun produced 0 false positives and 0 false negatives.
Independent review then found that system, design, and theme records were omitted from several authority enumerations. The corrected authority matrix now passes with 0 false positives and 0 false negatives, including a current system-owned AST-005 navigation-sink case and a current theme-application provider-precedence case.
Existing non-credited tests do not block this specification. They become cleanup-worthy only when they freeze private implementation, duplicate maintenance, or replace capable evidence.
Overlap receipt
docs/specs/AST-029/spec.md.Future B1–B16 migration handoff
A separate rubric activation after this record lands must retire B1–B16 as generic product-behavior IDs, preserve Behavior scoring from applicable authority, score Testing from this record, reserve B12, move B16 to PR/audit-run evidence, and bump the rubric minor version.
This PR does not edit the wiki rubric, scoring code, audit prompt, tests, tooling, or CI.
Validation
node scripts/check-knowledge.mjspnpm check:syncgit diff --checkLength rationale
The 331-line record intentionally exceeds the 200-line soft ceiling because it contains three durable review surfaces that would otherwise become ambiguous or drift apart: the no-new-test decision table, the explicit B1–B16 rubric migration handoff, and the mutation/failure verification matrix. Removing them would move the actual decision rules back into PR context or future implementation inference.
One architecture record only. No implementation, tests, tooling, wiki, audit-table, rubric, or Changeset edits.