Repository navigation
feat(core): BottomSheetSwitcher ordered activeSheets path (AST-044) #6728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
imdreamrunner
wants to merge
6
commits into
main
Choose a base branch
from
feat/switcher-active-sheets
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
4d5804a
feat(core): BottomSheetSwitcher ordered activeSheets path (AST-044)
imdreamrunner a525921
docs(core): make the activeSheets drill-in stack the primary BottomSh…
imdreamrunner 13681e0
docs(core): unify the BottomSheetSwitcher example into one activeShee…
imdreamrunner 35784c2
feat(core): prototype depth blur + example height parity for stacked …
imdreamrunner dfa99a3
fix(core): soften prototype depth filter; natural-height parity via c…
imdreamrunner b678f81
docs(core): trim one help-sheet row for closer natural height parity
imdreamrunner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| --- | ||
| '@astryxdesign/core': patch | ||
| --- | ||
|
|
||
| [feat] Add the BottomSheetSwitcher ordered-path API (`activeSheets`). | ||
|
|
||
| `BottomSheetSwitcher` now accepts a controlled `activeSheets` list — the | ||
| bottom-to-top path of open sheet ids — plus `onActiveSheetsChange(nextIds, | ||
| {reason, dismissedSheetId})` and `finalFocusRef`. Appending an id pushes a | ||
| drill-in sheet above the current one (which stays mounted, inert, and visually | ||
| receded), removing the final id pops back and restores that sheet's recorded | ||
| focus, replacing a suffix changes branch, and `[]` closes the flow. Only the | ||
| top sheet is interactive; implicit dismissal (Escape, modal-scrim click, or | ||
| swipe, per the top sheet's `purpose`) requests the path without its final id. | ||
| Invalid, repeated, unknown, or ambiguously registered ids present the longest | ||
| valid prefix and warn in development. | ||
|
|
||
| The change is additive: the released singular `activeSheet` / | ||
| `onActiveSheetChange` pair keeps its exact shipped behavior as a length ≤ 1 | ||
| projection of the list, `hasScrim` keeps its released meaning at every path | ||
| length, and no exports change. | ||
|
|
||
| @imdreamrunner | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Singular ids now go through the prefix rule: an
activeSheetthat no mounted sheet registers used to open the dialog and now stays closed with a warning namingactiveSheets[0]. Either keep the shipped singular handling or describe the change here.