Repository navigation
fix(specs): use current repository approver membership - #7538
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
AI review status for this pull request.
|
|
AI review status for this pull request.
|
Contributor
PR Analysis Report
No new or modified components detected. Bundle Size SummaryNo component packages changed. Accessibility AuditStatus: No accessibility violations detected. Visual Regression44 of 454 shot(s) changed. A change here is a question, not a failure: check whether the after is the
and 24 more. Generated by PR Enrichment workflow | View full report |
nynexman4464
marked this pull request as ready for review
October 15, 2026 17:50
nynexman4464
requested review from
cixzhang,
imdreamrunner and
josephfarina
as code owners
October 15, 2026 17:50
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Primary intent
Make
check:knowledgeuse current repository approver membership instead of the historical approver lists embedded in immutable schemas.Cause and impact
The repository's approval rules and PR gate already recognize every ENGOWNER for every current knowledge-record kind, with DESIGNOWNERS additionally eligible for design/theme. Local validation still used the old schema lists for most kinds, so an eligible owner could not promote a valid record.
Fix
This is a tooling prerequisite for the i18n/RTL record updates in #6048, #6046, and #6047. It grants no membership, supplies no approval, and changes no product behavior.
Evidence
The 21 added permission cases cover seven record kinds, removed historical approvers, and design-only eligibility. On the old validator, 12 cases fail; on the corrected validator all 121 knowledge tests pass. Existing missing/unauthorized-approval checks remain in place. Repository guardrails, formatting, and diff checks pass.
No workflows, schemas, component code, or review-request automation are changed.