Skip to content

fix(specs): use current repository approver membership - #7538

Merged
nynexman4464 merged 1 commit into
mainfrom
nynexman4464/fix/spec-owner-validation
Oct 15, 2026
Merged

nynexman4464 merged 1 commit into
mainfrom
nynexman4464/fix/spec-owner-validation

Conversation

@nynexman4464

Copy link
Copy Markdown
Contributor

Primary intent

Make check:knowledge use current repository approver membership instead of the historical approver lists embedded in immutable schemas.

Cause and impact

The repository's approval rules and PR gate already recognize every ENGOWNER for every current knowledge-record kind, with DESIGNOWNERS additionally eligible for design/theme. Local validation still used the old schema lists for most kinds, so an eligible owner could not promote a valid record.

Fix

  • Read ENGOWNERS for all record kinds.
  • Add DESIGNOWNERS eligibility only for design/theme.
  • Remove the schema-list fallback, so removed members do not retain approval eligibility through historical metadata.
  • Preserve immutable schemas, membership files, and the requirement for a real dated approval.

This is a tooling prerequisite for the i18n/RTL record updates in #6048, #6046, and #6047. It grants no membership, supplies no approval, and changes no product behavior.

Evidence

The 21 added permission cases cover seven record kinds, removed historical approvers, and design-only eligibility. On the old validator, 12 cases fail; on the corrected validator all 121 knowledge tests pass. Existing missing/unauthorized-approval checks remain in place. Repository guardrails, formatting, and diff checks pass.

No workflows, schemas, component code, or review-request automation are changed.

@vercel

vercel Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
astryx Ready Ready Preview Oct 14, 2026 7:01pm UTC

Request Review

@astracat-bot

astracat-bot Bot commented Oct 14, 2026

Copy link
Copy Markdown

AI review status for this pull request.

Review status Updated
📝 Draft — not reviewed automatically (for maintainers only) Oct 14, 2026, 6:51 PM UTC

@astracat-bot

astracat-bot Bot commented Oct 14, 2026

Copy link
Copy Markdown

AI review status for this pull request.

Review status Updated
📝 Draft — not reviewed automatically (for maintainers only) Oct 14, 2026, 6:52 PM UTC

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 14, 2026
@github-actions

Copy link
Copy Markdown
Contributor

PR Analysis Report

Preview availability: Storybook and Sandbox are not both ready on the exact-head Vercel preview.

No new or modified components detected.

Bundle Size Summary

No component packages changed.

Accessibility Audit

Status: No accessibility violations detected.

Visual Regression

44 of 454 shot(s) changed.

A change here is a question, not a failure: check whether the after is the
picture you intended. Record that review on the PR. Baseline maintenance is an
explicit dispatch of CI; this report never rewrites the baseline or adds a release gate.

component story theme mode pixels
Selector Indicator Space Bottom Sheet Narrow End RTL neutral light 754,077
Selector Indicator Space Bottom Sheet Wide Start neutral light 740,188
Chat Full AI Chat probe light 238,081
Chat Full AI Chat probe dark 237,048
Markdown Default probe light 159,625
Markdown Default probe dark 158,986
Collapsible Dividers probe dark 66,445
Collapsible Dividers probe light 66,445
Chat Default neutral dark 33,205
Chat Default neutral light 32,876
Chat Empty State probe light 23,531
Chat Empty State probe dark 22,622
ChatAutoScroll Scroll Behavior Comparison neutral dark 15,378
ChatAutoScroll Scroll Behavior Comparison neutral light 14,107
Chat With Attachments probe light 13,406
Chat With Attachments probe dark 11,232
ProgressBar With Target Mark probe dark 7,895
ProgressBar With Target Mark probe light 7,895
TableRowExpansion Detail Panel neutral dark 5,150
TableRowExpansion Detail Panel neutral light 4,068

and 24 more.


Generated by PR Enrichment workflow | View full report

@nynexman4464
nynexman4464 marked this pull request as ready for review October 15, 2026 17:50
@nynexman4464
nynexman4464 merged commit c529db2 into main Oct 15, 2026
56 checks passed
@github-actions
github-actions Bot deleted the nynexman4464/fix/spec-owner-validation branch October 16, 2026 06:22

This branch was successfully deployed

1 active deployment
Preview — a09f143b Deployed Oct 14, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant