Skip to content

spec(cli-surface): the integration doc checks govern from the CLI surface record - #7686

Merged
josephfarina merged 1 commit into
mainfrom
josephfarina/integration-doc-checks-current
Oct 18, 2026
Merged

josephfarina merged 1 commit into
mainfrom
josephfarina/integration-doc-checks-current

Conversation

@josephfarina

Copy link
Copy Markdown
Contributor

Exact decision needed

The rules for the integration doc checks (documented props agree with the source, every descriptor satisfies its published authoring type, and astryx integration check) are approved text in spec:AST-039 FR12–FR14. That record is a draft, and only current records govern. This PR makes the three rules govern from the current architecture:cli-surface record without changing a word.

Existing authority searched

Decision

  • INV33, INV34 and INV35 are FR12, FR13 and FR14, word for word. INV35's reference to INV32 drops its record prefix.
  • Their evidence rows name the tests that prove them.
  • DEC-5 records that this record governs them.
  • spec:AST-039 FR12–FR14 keep their titles and point to INV33–INV35.

Rejected alternatives

  • Marking all of spec:AST-039 current: that would also approve FR1–FR11, which this decision does not cover.

Claim scope and non-goals

Only these three rules. INV32, DEC-4 and the rest of spec:AST-039 are unchanged, and spec:AST-039 stays a draft.

Evidence and implementation relationship

The record owner approved this text in #7658. Implementation: #7681, #7663, #7676, #7684 and #7667 (INV33); #7664 and #7673 (INV34); #7665 (INV35). The evidence rows name the tests those PRs add.

Writing rubric results

  • R1 narration: none in the added text; DEC-5 and the pointers state where each rule lives, in the present tense.
  • R2 research in the record: none.
  • R3 evidence naming a change: none; the new rows name test files.
  • R4 rejected alternatives over one line or outside a decision: one, inside DEC-5, one line.
  • R5 pull request or issue references remaining: none.
  • R6 ruled open questions still listing options: none touched.

Scope

  • This PR contains specification records only.
  • It records observable behavior and preserves equivalent internal implementations.
  • Any named internal mechanism is intentionally public, names its dependent caller/system, and explains why an equivalent implementation would not satisfy the contract.
  • Verification states the evidence layer and failure signal without prescribing CI job/workflow topology.
  • It records one intentional durable decision, not a rescue for a separable tagalong.
  • The canonical knowledge owner, affected current claims, and overlapping open work are named; any ownership collision is resolved or called out for human decision.
  • Adjacent API, visual, accessibility, composition, and implementation facts remain outside scope unless this exact decision depends on them.
  • Public text and artifacts contain no internal Meta context.

Validation

  • pnpm check:knowledge: templates and records are aligned.
  • Prettier: spec:AST-039 is clean. architecture:cli-surface already differs from Prettier on main (its Verification table rows are not padded), so the new rows follow the INV32 row's style rather than re-padding the table.
  • git diff --check: clean.

…face record

INV33, INV34 and INV35 state spec:AST-039 FR12, FR13 and FR14 word for word:
documented props agree with the source, every descriptor satisfies its
published authoring type, and one command checks an integration and can gate
its build. DEC-5 records that this record governs them, and AST-039 FR12-FR14
point here.
@vercel

vercel Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
astryx Ready Ready Preview Oct 18, 2026 7:53pm UTC

Request Review

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 18, 2026
@astracat-bot

astracat-bot Bot commented Oct 18, 2026

Copy link
Copy Markdown

AI review status for this pull request.

Review status Updated
🔄 In progress (for maintainers only) Oct 18, 2026, 7:48 PM UTC

@josephfarina

Copy link
Copy Markdown
Contributor Author

/approve-spec 9b28894

@github-actions

Copy link
Copy Markdown
Contributor

PR Analysis Report

Previews ready: Storybook and Sandbox were built with this PR's docsite. CI evidence will be added when available.

View Storybook for this PR · View Sandbox for this PR

@josephfarina
josephfarina merged commit 5814894 into main Oct 18, 2026
52 checks passed
@github-actions
github-actions Bot deleted the josephfarina/integration-doc-checks-current branch October 19, 2026 06:30

This branch was successfully deployed

1 active deployment
Preview — 9b288944 Deployed Oct 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant