Repository navigation
spec(cli-surface): the integration doc checks govern from the CLI surface record - #7686
Merged
Merged
Conversation
…face record INV33, INV34 and INV35 state spec:AST-039 FR12, FR13 and FR14 word for word: documented props agree with the source, every descriptor satisfies its published authoring type, and one command checks an integration and can gate its build. DEC-5 records that this record governs them, and AST-039 FR12-FR14 point here.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
AI review status for this pull request.
|
Contributor
Author
|
/approve-spec 9b28894 |
Contributor
PR Analysis Report
|
github-actions
Bot
deleted the
josephfarina/integration-doc-checks-current
branch
October 19, 2026 06:30
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exact decision needed
The rules for the integration doc checks (documented props agree with the source, every descriptor satisfies its published authoring type, and
astryx integration check) are approved text inspec:AST-039FR12–FR14. That record is a draft, and only current records govern. This PR makes the three rules govern from the currentarchitecture:cli-surfacerecord without changing a word.Existing authority searched
architecture:cli-surface(current): INV18 (integration diagnostics are read-only), INV24 (descriptors), INV32 and DEC-4 (--strict). None states the doc checks themselves.spec:AST-039(draft): FR12–FR14 hold the approved text.architecture:cli-surface: spec(cli-surface): INV30, how a host's package set serves the CLI #7412 (INV30), spec(cli-surface): agent docs reach every agent from the project's own files #7539 (INV31, DEC-2); spec(AST-081): global mode, so the CLI answers in any folder and a project's own release answers inside it #7601, test(a11y): bind Banner urgent alert states #6779 and spec: AST-060 integration package init #6963 add no ids. INV33–INV35 and DEC-5 are unused.Decision
spec:AST-039FR12–FR14 keep their titles and point to INV33–INV35.Rejected alternatives
spec:AST-039current: that would also approve FR1–FR11, which this decision does not cover.Claim scope and non-goals
Only these three rules. INV32, DEC-4 and the rest of
spec:AST-039are unchanged, andspec:AST-039stays a draft.Evidence and implementation relationship
The record owner approved this text in #7658. Implementation: #7681, #7663, #7676, #7684 and #7667 (INV33); #7664 and #7673 (INV34); #7665 (INV35). The evidence rows name the tests those PRs add.
Writing rubric results
Scope
Validation
pnpm check:knowledge: templates and records are aligned.spec:AST-039is clean.architecture:cli-surfacealready differs from Prettier on main (its Verification table rows are not padded), so the new rows follow the INV32 row's style rather than re-padding the table.git diff --check: clean.