Repository navigation
test(lab): MobilePowerSearch tests read the interactive step's dialog; regenerate the official package list - #7978
Closed
imdreamrunner wants to merge 1 commit into
Closed
imdreamrunner wants to merge 1 commit into
imdreamrunner wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
meta-cla
Bot
added
the
CLA Signed
4 tasks done
|
AI review status for this pull request.
|
imdreamrunner
enabled auto-merge (squash)
October 23, 2026 18:16
Contributor
PR Analysis Report📚 Storybook Preview🧪 Sandbox PreviewModified ComponentsMobilePowerSearch (@astryxdesign/lab) · View in Storybook
Bundle Size Summary
Accessibility AuditStatus: No accessibility violations detected. Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
…; regenerate the official package list Each BottomSheetSwitcher step now owns its native dialog, and through a handoff the outgoing step's dialog stays open, inert and aria-hidden. The tests' sheet() helper read the first open dialog, which can be that leaving step, so 41 of 79 MobilePowerSearch tests failed on main. It now returns the first open dialog that is not hidden; no test changes otherwise. The Lab component it covers was added without regenerating the CLI's official package list, so the list's drift guard failed too. The list is regenerated with `pnpm bundle:cli-official-packages` and now names MobilePowerSearch.
imdreamrunner
force-pushed
the
fix/lab-mobile-powersearch-tests-per-step-dialogs
branch
from
October 23, 2026 18:24
058af0f to
22aa5bd
Compare
imdreamrunner
changed the title
Contributor
Author
auto-merge was automatically disabled
October 23, 2026 18:47
Pull request was closed
imdreamrunner
deleted the
fix/lab-mobile-powersearch-tests-per-step-dialogs
branch
October 23, 2026 18:47
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maintainer impact
mainis red: 41 of the 79 tests inpackages/lab/src/MobilePowerSearch/MobilePowerSearch.test.tsxfail. #7402 (MobilePowerSearch) was tested before #7720 merged; since #7720 eachBottomSheetSwitcherstep owns its native dialog, and the tests'sheet()helper still read the firstdialog[open]as the active step. After any step change that first dialog is the outgoing step, which stays open, inert andaria-hiddenuntil a fade that jsdom never fires, so queries scoped to it miss the step on screen. Every pull request that runs the lab suite inherits the failure. The same merge also left the CLI's official package list stale:scripts/check-cli-official-packages.test.mjs(theastryx discoverdrift guard,spec:AST-051FR11) fails because the committed list does not name the new Lab componentMobilePowerSearch.Intended invariant
component:BottomSheetSwitcher(current) FR2: a handoff presents the entering sheet's dialog above the retained one and closes the retained dialog only after its panel has faded; the retained dialog is inert and hidden from assistive technology meanwhile. The helper must return the step the person is interacting with.Change
sheet()returns the first open dialog that is notaria-hidden. Test-only.packages/cli/assets/discover/official-packages.jsonis regenerated withpnpm bundle:cli-official-packages; the only change is the addedMobilePowerSearchcomponent entry, the output of the existing generator.Evidence
main,pnpm exec vitest run packages/lab/src/MobilePowerSearch/MobilePowerSearch.test.tsx→ 41 failed, 38 passed (79).pnpm exec vitest run --project node scripts/check-cli-official-packages.test.mjsfails onmain(list missingMobilePowerSearch) and passes after regeneration (14 passed).Scope
Testing
pnpm exec vitest run packages/lab/src/MobilePowerSearch/MobilePowerSearch.test.tsx: 79 passed.pnpm exec vitest run --project node scripts/check-cli-official-packages.test.mjs: 14 passed.