Repository navigation
Conversation
INV10's surface roles gain `backdrop`, the dim behind a modal, and `glass`, the surface behind bar buttons, so `--color-background-backdrop` and `--color-background-glass` are shape-1 names. The guard test's surface list follows and names both.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
AI review status for this pull request.
|
There was a problem hiding this comment.
Approval is on hold for an owner decision: this pull request intentionally changes the current architecture:theme-tokens INV10 by adding backdrop and glass to its surface roles, and that update to the existing spec needs an engineering owner's approval. An engineering owner records the decision by commenting /approve-spec <full head SHA> on this pull request; you are listed in .github/ENGOWNERS, so you may record it yourself. The record sentence and the guard test are consistent, so nothing else blocks.
- Please correct the rejected alternative about
--color-overlaybefore the decision: onmainit also paints the::backdropof Dialog, Drawer, BottomSheet, MobileNav and Lightbox, sobackdropsplits that token's job. - The decision should also settle whether
glass, a material name, fits INV3's purpose-led naming or the role should be named for the place it serves.
[Automated review]
PR Analysis Report📚 Storybook Preview🧪 Sandbox PreviewNo new or modified components detected. Bundle Size Summary
Accessibility AuditStatus: No accessibility violations detected. Visual Regression46 of 502 shot(s) changed. A change here is a question, not a failure: check whether the after is the
and 26 more. Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
|
Posted by Cindy's agent on her behalf. Following the decision on #8120 (the overlay stays theme-controlled through |
|
Posted by Cindy's agent on her behalf. With #8120 narrowed to a blur-only performance fix, this PR isn't needed: there's no |
|
Closing, as recommended in the 03:43 review: with #8120 narrowed to a blur-only performance fix there is no |
Proposed; pending owner review (cixzhang, owner of
architecture:theme-tokens).Exact decision needed
Should INV10's surface roles include
backdrop(the dim behind a modal) andglass(the surface behind bar buttons), making--color-background-backdropand--color-background-glassshape-1 names?Existing authority searched
architecture:theme-tokensINV10 (current): shape 1 is--color-<property>-<role>; surface roles aresurface,body,card,popover,muted,inverted. The role-less utility names form a closed list.--color-overlayis the media scrim (Overlay, Thumbnail), not a modal dim.Decision
INV10 shape 1 accepts two more surface roles:
backdrop, the dim behind a modal presentation, andglass, the surface behind bar buttons. The guard test's surface list gains both; the rest of the grammar is unchanged.Rejected alternatives
--color-dim): they grow the closed utility list.--color-overlay: it is the media scrim.Claim scope and non-goals
Only the two role names. No tokens, values, components or platform behaviour; #8120 and #8188 carry those.
Evidence and implementation relationship
#8120 and #8188 depend on this. The guard test (
tokens.test.ts › colour token name grammar) checks every Astryx colour token against the grammar.Writing rubric results
Scope
Validation
pnpm check:knowledge: records aligned.pnpm exec vitest run packages/core/src/theme/tokens.test.ts: 30 pass, including the grammar's guard and the two new role names.git diff --checkis clean.