Repository navigation
Conversation
interaction-scope checked out GitHub's merge commit, but its helper diffs from the merge base to HEAD and expects the pull request head (as pr-a11y checks out). When the reported base lags main, the diff counted what main gained since (the proofs' own config, once they landed) as the pull request's change, so a head cut before the proofs ran them on a tree with no config, and failed. The new routing test builds that history for real (a bare origin with the base, main gaining the config, heads and their merge commits), clones what the job's checkout names, and runs the step with the repository's helper.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
AI review status for this pull request.
|
PR Analysis Report📚 Storybook Preview🧪 Sandbox PreviewNo new or modified components detected. Bundle Size SummaryNo component packages changed. Accessibility AuditStatus: No accessibility violations detected. Visual Regression48 of 502 shot(s) changed. A change here is a question, not a failure: check whether the after is the
and 28 more. Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
|
Superseded by #8812, which makes |
User impact
Pull requests cut before #8043 that change a component fail
pr-interaction("playwright.interaction.config.ts does not exist"), andtestwith it: #8229 (approved), #8055 and #8056 so far. The routing's own rule is that such a head passes with the "Interaction proofs predate this branch" notice.Problem and solution fit
pr-scope-touches.sh, which diffs from the merge base toHEAD.interaction-scopechecked out GitHub's merge commit, not the head. On feat(Popover): presentation — a BottomSheet on a phone when asked, as iOS presents a popover #8229 the event's base was17fead75b9, before test(interaction): real touch input for browser interaction proofs #8043, while the merge commit sits on main, so the diff counted what main gained since, the config included, as the pull request's change.Checking out the head, as the helper expects and
pr-a11ydoes, fixes it.Expected behavior and authority
The decide step's contract, in its comment and in
.github/scripts/ci-interaction.test.mjs: a head cut before the proofs passes with a notice; one that deletes their config still runs them.spec:AST-030FR9: routing tests are mutation-sensitive; this adds the missing near miss, a base that lags main.Smallest restoration
One
ref: ${{ github.event.pull_request.head.sha }}oninteraction-scope's checkout, with a comment. The decide script, helper andpr-interactionare unchanged.Evidence
applies=truefor a head cut before the proofs with the base it was cut from, as in the feat(Popover): presentation — a BottomSheet on a phone when asked, as iOS presents a popover #8229 run.applies=falsewith the notice, with that base and the current one.applies=true; existing cases are unchanged.reffails it.Scope
Testing
pnpm exec vitest run .github/scripts/ci-interaction.test.mjs .github/scripts/ci-duration-guard.test.mjs: 33 passed. The new case failed first on main's workflow (applies=true).pnpm exec vitest run .github/scripts: 73 files, 1,335 tests passed.pnpm exec prettier --check .github/workflows/ci.yml .github/scripts/ci-interaction.test.mjs: clean.pull_requesttrigger lists notypes, so the defaultreopenedruns CI again on a new merge commit carrying this workflow, with the head unchanged; a re-run would reuse the old merge commit.