Repository navigation
spec(native): Swift Icon and Avatar records use main's component template (3/7) - #8475
Conversation
…late, schema 3 / template 7
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
AI review status for this pull request.
|
|
/approve-spec 1b95934 |
PR Analysis Report
|
There was a problem hiding this comment.
Recommended for approval: both records now name schema 3 and template 7, the component template main defines, as spec:AST-093 FR1 and knowledge-contracts INV27 require, and the kept platform_of and component:swift/<Name> ids are the gap knowledge-contracts already documents until the next schema. One note on the description: check:knowledge does not read files under packages/native/apple/Sources/ yet and passes on the base the same way, so it is not evidence for these two records, which are checked by review. When #8288 adds schema 5, it will need to move both records again.
[Automated review]
User need
A reviewer checking a Swift component record against the repository's component template should find the template the record names. Icon's and Avatar's Swift records name schema 5 / template 8, which main does not define yet. Main's component template is schema 3 / template 7.
Problem and solution fit
Both records now name schema 3 / template 7.
platform_ofstays, since main'scheck:knowledgeaccepts it. The pending knowledge migration converts every 3/7 record to its next schema when it lands, so these records follow it with the rest.Current specification
docs/templates/knowledge/component-spec.mdon main:schema_version: 3,template_version: 7.Public delta and caller burden
None. Two frontmatter lines in each of two records.
Design and alternatives
Keeping 5/8 until the migration lands would leave main's records naming a template main does not have.
Evidence
check:knowledgeon main with the change: "Knowledge templates and records are aligned."Open-work search
Searched open pull requests for
Icon.spec.md,Avatar.spec.md, andschema_versionunderpackages/native. The AvatarStatusDot pull request (#8328) moves its own record to 3/7 too. The knowledge migration pull request (#8288) converts records from 3/7.Scope
Writing rubric results
Testing
check:knowledgepasses.Changed files:
packages/native/apple/Sources/Astryx/Icon/Icon.spec.mdandpackages/native/apple/Sources/Astryx/Avatar/Avatar.spec.md.