Skip to content

spec(native): Swift Icon and Avatar records use main's component template (3/7) - #8475

Merged
cixzhang merged 1 commit into
mainfrom
native/spec-swift-frontmatter-3-7
Oct 26, 2026
Merged

cixzhang merged 1 commit into
mainfrom
native/spec-swift-frontmatter-3-7

Conversation

@cixzhang

Copy link
Copy Markdown
Contributor

User need

A reviewer checking a Swift component record against the repository's component template should find the template the record names. Icon's and Avatar's Swift records name schema 5 / template 8, which main does not define yet. Main's component template is schema 3 / template 7.

Problem and solution fit

Both records now name schema 3 / template 7. platform_of stays, since main's check:knowledge accepts it. The pending knowledge migration converts every 3/7 record to its next schema when it lands, so these records follow it with the rest.

Current specification

  • docs/templates/knowledge/component-spec.md on main: schema_version: 3, template_version: 7.

Public delta and caller burden

None. Two frontmatter lines in each of two records.

Design and alternatives

Keeping 5/8 until the migration lands would leave main's records naming a template main does not have.

Evidence

  • check:knowledge on main with the change: "Knowledge templates and records are aligned."

Open-work search

Searched open pull requests for Icon.spec.md, Avatar.spec.md, and schema_version under packages/native. The AvatarStatusDot pull request (#8328) moves its own record to 3/7 too. The knowledge migration pull request (#8288) converts records from 3/7.

Scope

  • One capability is added.
  • Unrelated fixes, cleanup, and policy changes were removed or split.
  • Consumer docs, focused tests, and migration evidence ship with the feature.
  • Public text and artifacts contain no internal Meta context.

Writing rubric results

  • R1–R6: no record prose changes; frontmatter only.

Testing

  • check:knowledge passes.

Changed files: packages/native/apple/Sources/Astryx/Icon/Icon.spec.md and packages/native/apple/Sources/Astryx/Avatar/Avatar.spec.md.

@vercel

vercel Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
astryx Ready Ready Preview Oct 26, 2026 1:48am UTC

Request Review

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 26, 2026
@astracat-bot

astracat-bot Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

AI review status for this pull request.

Review status Updated
🟢 Reviewed (for maintainers only) Oct 26, 2026, 2:17 AM UTC

@cixzhang

Copy link
Copy Markdown
Contributor Author

/approve-spec 1b95934

@github-actions

Copy link
Copy Markdown
Contributor

PR Analysis Report

Previews ready: Storybook and Sandbox were built with this PR's docsite. CI evidence will be added when available.

View Storybook for this PR · View Sandbox for this PR

@astracat-bot astracat-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommended for approval: both records now name schema 3 and template 7, the component template main defines, as spec:AST-093 FR1 and knowledge-contracts INV27 require, and the kept platform_of and component:swift/<Name> ids are the gap knowledge-contracts already documents until the next schema. One note on the description: check:knowledge does not read files under packages/native/apple/Sources/ yet and passes on the base the same way, so it is not evidence for these two records, which are checked by review. When #8288 adds schema 5, it will need to move both records again.

[Automated review]

@cixzhang
cixzhang merged commit 70239fe into main Oct 26, 2026
72 checks passed
@github-actions
github-actions Bot deleted the native/spec-swift-frontmatter-3-7 branch October 26, 2026 06:31

This branch was successfully deployed

1 active deployment
Preview — 1b959349 Deployed Oct 26, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant