Repository navigation
chore(core): the internal module for size-change glides (spec:AST-105, INV12) #8482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
5b0abfb
b476220
52c08dc
7cfe5e0
e2afc61
dc023f3
b60f171
ac58ce3
427f850
1bccf04
b894315
ea01d0c
186526e
5bcb797
7bad709
3a5f9ae
b3826b7
a09ce74
2f7cedb
52841d7
bc32d66
e4b19b0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| '@astryxdesign/core': patch | ||
| --- | ||
|
|
||
| [chore] Internal: the one module for size-change glides (`spec:AST-105`, `architecture:react-component-runtime` INV12). After a reported size change, the content after it inside a container glides to its new place on one shared internal motion role, and the changed element enters or exits on the same motion. Not exported; no component uses it yet. The public `useAnimatedLayout` hook and Collapsible's and TreeList's `animatedLayout` prop arrive together in a later release. | ||
|
|
||
| @cixzhang |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -164,8 +164,9 @@ those contracts. | |
| `spec:AST-105` defines. It measures the layout before and after a reported | ||
| change and moves shifted content with a compositor-only translate played | ||
| through the shared rectangle morph (`architecture:layer-runtime` INV15; | ||
| `spec:AST-094` FR5); it never animates height. Its walk visits only the | ||
| following element siblings at each ancestor level up to the area, through | ||
| `spec:AST-094` FR5) once Core has that morph; until then, the module plays | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This amends INV12, which currently requires the glide to play through the shared rectangle morph. The interim needs an engineering owner's decision ( There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This rewords INV12, which on |
||
| its own compositor translate. It never animates height. Its walk visits only | ||
| the following element siblings at each ancestor level up to the area, through | ||
| `parentElement` and `nextElementSibling`, descending only into an element | ||
| with `display: contents`, so its cost grows with depth plus following | ||
| siblings. Changes in one area in the same frame are measured together. A | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes INV12 itself: today it requires the glide to play through the shared rectangle morph. The interim needs an engineering owner's
/approve-specon this head; until then the module's own translate contradicts the current invariant.