Repository navigation
spec(Popover): a Popover is a focus region, modal or not (DEC-9) - #8608
Merged
Merged
Conversation
A Tab pressed outside an open popover follows the page's order instead of being pulled into the popover; focus inside still cycles. Records the owner decision for #7687.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
AI review status for this pull request.
|
Contributor
Author
|
/approve-spec fc503c0 |
Contributor
PR Analysis Report
|
4 tasks done
vjeux
added a commit
to vjeux/astryx
that referenced
this pull request
Oct 27, 2026
Main's meta#8608 (DEC-9, a Popover is a focus region) added two Tab rows to the focus-entry matrix beside this branch's anchor-rectangle row; both stay.
4 tasks done
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exact decision needed
How an open Popover treats Tab. Today a non-modal Popover pulls a Tab pressed anywhere on the page into itself (#7687), so keyboard users can't move through the rest of the page while it is open.
Existing authority searched
component:Popover(AR3, AV3, the focus and dismissal state matrix): it covers Tab from a focused container only and says nothing about a Tab that starts outside the popup.useFocusTrappublic docs: "redirects focus back into the container if it escapes". They do not say whether a Tab that never started inside is redirected.architecture:layer-runtime,family:overlay-dismissalandarchitecture:interaction-modalityleave focus containment to Popover.usePopover; dialog popups (ComplexSelector, the date input calendars, the SideNavItem flyout, DropdownMenu with a header or footer, the Lab Schedule popover); role-neutral menus (DropdownMenu, TabMenu, Breadcrumbs overflow, SideNav and TopNav heading menus); listbox popups (Typeahead, PowerSearch, Selector, the Chat trigger menu); TopNavMegaMenu. Tooltip, HoverCard, Toast and ContextMenu have no focus trap.Decision
The owner decided: a Popover is a focus region, like a dialog's, whether it is modal or not.
isModalchanges only the modal semantics.Rejected alternatives
Claim scope and non-goals
Only Popover's Tab handling. Not changed: Escape and light-dismiss policy, initial focus, focus return, the
isModalsemantics, and each role-neutral popup's own keyboard model. No public API change.Evidence and implementation relationship
The reporter's reproduction in #7687, and two contributors' real-browser checks there (Chrome, Safari). The implementation PR follows this one.
Writing rubric results
Scope
Validation
pnpm check:knowledge: alignedgit diff --check: clean