Skip to content

sandbox(motion-lab): regenerate the motion audit against core@0.7.5 - #8620

Merged
cixzhang merged 1 commit into
mainfrom
sandbox/motion-audit-regenerate
Oct 27, 2026
Merged

cixzhang merged 1 commit into
mainfrom
sandbox/motion-audit-regenerate

Conversation

@cixzhang

Copy link
Copy Markdown
Contributor

What changes for the person using the lab

The Motion Lab shows numbers from a generated audit of core's motion code instead of hand-written ones. The checked-in audit was last measured against core@0.5.2, so the lab's counts describe a release from months ago. This regenerates it against the current core.

Change

apps/sandbox/src/app/(sandbox)/pages/motion-lab/__generated__/motionAudit.ts only, regenerated with:

pnpm -F @astryxdesign/sandbox generate:motion-audit

then formatted with prettier, like the checked-in file.

Generator output: core@0.7.5 (core + lab): 59 hardcoded values, 44 files without reduced motion, 40 transform transitions.

Scope

  • Generated file only. Sandbox, no changeset.
  • No hand edits.

Testing

  • Sandbox tsc on the motion-lab files is clean.

The Motion Lab's generated audit was last measured against core@0.5.2.
Regenerated with pnpm -F @astryxdesign/sandbox generate:motion-audit (then
prettier, as the checked-in file is formatted): core@0.7.5, core+lab: 59
hardcoded values, 44 files without reduced motion, 40 transform
transitions. Generated file only.
@vercel

vercel Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
astryx Ready Ready Preview Oct 26, 2026 11:46pm UTC

Request Review

@astracat-bot

astracat-bot Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

AI review status for this pull request.

Review status Updated
🟢 Reviewed (for maintainers only) Oct 27, 2026, 12:03 AM UTC

@github-actions

Copy link
Copy Markdown
Contributor

PR Analysis Report

Previews ready: Storybook and Sandbox were built with this PR's docsite. CI evidence will be added when available.

View Storybook for this PR · View Sandbox for this PR

@astracat-bot astracat-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to merge: the regenerated motionAudit.ts is exactly what the unchanged generator and prettier produce on this branch, and no current spec governs the sandbox Motion Lab. One correction to the description: the sandbox dev and build scripts already regenerate this file before serving, so labs served through them were already showing current counts and only the committed copy was stale. Optional before merge: main has moved since this branch's base, and regenerating there gives filesScanned: 919 and shifts 13 line references in BottomSheet, Drawer, Lightbox and MobileNav by one, so a rebase and rerun would make the snapshot match main exactly.

[Automated review]

hardcodedTotal: 58,
hardcodedDuration: 34,
hardcodedEasing: 24,
filesScanned: 917,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking: main moved after this branch's base (#8009). Regenerating at main's tip gives filesScanned: 919 here and raises 13 line references in BottomSheet.tsx, Drawer.tsx, Lightbox.tsx and MobileNav.tsx by one; rebasing and rerunning pnpm -F @astryxdesign/sandbox generate:motion-audit plus prettier would make the snapshot match main.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 27, 2026
@cixzhang
cixzhang merged commit bb24260 into main Oct 27, 2026
63 checks passed
@github-actions
github-actions Bot deleted the sandbox/motion-audit-regenerate branch October 27, 2026 06:22

This branch was successfully deployed

1 active deployment
Preview — 73eac662 Deployed Oct 26, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant