Repository navigation
feat(core): the animated-layout module's in-place swap (spec:AST-105 FR8) #8734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
61 commits
Select commit
Hold shift + click to select a range
5b0abfb
feat(core): useAnimatedLayout, one module that glides the layout shif…
cixzhang b476220
feat(core): useAnimatedLayout({containerRef}) returns a handle that C…
cixzhang 52c08dc
fix(core): the layout glide corrects only a real ancestor scale, not …
cixzhang 7cfe5e0
chore(storybook): the Animated layout story's tags row is narrow, so …
cixzhang e2afc61
Merge 8ba53b45a4 (main, AST-105 current) into the animated layout draft
cixzhang dc023f3
wip(core): animated layout follows AST-105 (springs.settle, Reduce Mo…
cixzhang b60f171
feat(core): useAnimatedLayout follows AST-105
cixzhang ac58ce3
chore(storybook): the story's internal-reporting demos say they are s…
cixzhang 427f850
chore(docsite): the ShadCN route lock lists the useAnimatedLayout hoo…
cixzhang 1bccf04
fix(core): the animated layout reads springs.settle from the internal…
cixzhang b894315
test(core): the animated-layout browser proofs settle between changes…
cixzhang ea01d0c
fix(core): animated layout measures every grouped change, drops refus…
cixzhang 186526e
fix(core): a retargeted glide keeps its motion and adds the new move
cixzhang 5bcb797
docs(architecture): INV12 plays the glide through the shared rectangl…
cixzhang 7bad709
docs(architecture): rewrap INV12
cixzhang 3a5f9ae
refactor(core): useAnimatedLayout lands alone; Collapsible and TreeLi…
cixzhang 7e13143
feat(core): Collapsible and TreeList adopt useAnimatedLayout
cixzhang b3826b7
feat(core): the changed element's exit, held out of flow on the same …
cixzhang f8c2db7
Merge the module's exit (feat/animated-layout) into the adoption
cixzhang 044b865
feat(core): a Collapsible's or TreeList row's close plays the content…
cixzhang 52863fc
test(core): the exiting group's rows leave the tree's keyboard order
cixzhang 1c44863
chore(changeset): Collapsible and TreeList adopt animatedLayout
cixzhang a09ce74
fix(core): the internal module alone; a displaced changed element mov…
cixzhang 980ff13
Merge feat/animated-layout into the adoption; the public hook and the…
cixzhang 2f7cedb
fix(core): the exit frees exactly its space and is inert; elements th…
cixzhang f97811a
Merge feat/animated-layout (an exact, inert exit; app-moved followers…
cixzhang 52841d7
fix(core): the exit measures the content after it, holds only a measu…
cixzhang 86a458b
Merge feat/animated-layout (the exit measures the content after it an…
cixzhang bc32d66
fix(core): nested changes compose in any order; the exit finds the re…
cixzhang ac812d7
Merge feat/animated-layout (nested changes in any order; the exit's n…
cixzhang e4b19b0
fix(core): the exit's correction follows a scaled ancestor, and its m…
cixzhang 731af79
Merge feat/animated-layout (scale-corrected exit; measured out of flo…
cixzhang c08d59b
fix(core): Collapsible and TreeList report every change, whatever cau…
cixzhang 7c96972
test(core): the adopters' browser spec serves Storybook through a11y-…
cixzhang 7ca7a04
fix(core): a TreeList row collapsing with an expanded child moves wha…
cixzhang 5695f69
docs(core): Collapsible FR10 and TreeList FR8 cite AST-108 FR4a for t…
cixzhang 8338da9
Merge main (#8482 landed as 7a530cc) into the adopters
cixzhang 4c4ac7b
feat(core): the animated-layout module's in-place swap (spec:AST-105 …
cixzhang 600302f
fix(core): an opaque swap copy paints the background it shows
cixzhang 7a86690
feat(core): a swap's copy can ride the glide of the element it sat in
cixzhang f7d0850
fix(core): a swap copy keeps its old rect, its canvas pixels and its …
cixzhang 007f414
docs(spec): Collapsible FR10 and TreeList FR8 cite AST-105 for the sh…
cixzhang 0d2c364
Merge remote-tracking branch 'origin/feat/animated-layout-adopters' i…
cixzhang f2f3d64
fix(core): a swap copy labels no live control, keeps nested scroll, a…
cixzhang 36c6fd8
Merge main: TreeList's animatedLayout row is FR9 beside main's FR8; a…
cixzhang 5da9a6b
Merge remote-tracking branch 'origin/feat/animated-layout-adopters' i…
cixzhang d771226
fix(core): the glide moves an element by its inline-start edge, so a …
cixzhang 9fbc118
fix(core): swap copies land scroll at once, keep their size under a s…
cixzhang 72a67c3
fix(core): a swap copy reads its canvases at full size and its scale …
cixzhang 2f074f8
fix(core): a ridden copy starts where it was laid; a fractional copy …
cixzhang 8148cfe
fix(core): playLayoutFrames releases its frames when the motion ends
cixzhang b150c15
feat(core): a new change can take a swap's copy over mid-swap (handOff)
cixzhang 013de65
feat(core): a swap calls onEnd when it ends
cixzhang 30453d8
Merge remote-tracking branch 'origin/main' into feat/animated-layout-…
cixzhang f6c8eab
fix(core): a handed-off swap copy keeps its travel, clip and text fad…
cixzhang 179b3bf
feat(core): every part of a ridden swap plays over the ridden glide a…
cixzhang a234c3c
fix(core): a swap copy laid outside its ancestors keeps what it inher…
cixzhang 9b6ad1c
fix(core): a swap copy carries a unitless line-height as its factor
cixzhang 81388fd
fix(core): without a typed style map, a swap copy carries its line-he…
cixzhang 3e3322e
fix(core): a swap copy keeps a length line-height as its pixels
cixzhang 1cf5eab
Merge origin/main into feat/animated-layout-swap; a swap copy always …
cixzhang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| '@astryxdesign/core': patch | ||
| --- | ||
|
|
||
| [fix] The animated-layout module gains its internal in-place swap: old content held as one inert, transient copy while new content enters in its place, on the shared motion. Nothing uses it yet and nothing public changes. In right-to-left containers, content after a Collapsible or TreeList size change (with an `animatedLayout` handle) now glides by its inline-start edge instead of jumping. | ||
|
|
||
| @cixzhang |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional: the public-entry check above names only the four reporting functions. Adding
holdLayoutSwap,playLayoutSwapandplayLayoutFramesto its list would makespec:AST-105FR8's "a public export fails" mechanical; none of them is exported today.