Repository navigation
docs(SideNav, AppShell): the rail collapse motion is implemented (FR6, FR17) - #8790
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
/approve-spec 8b9118a |
meta-cla
Bot
added
the
CLA Signed
|
AI review status for this pull request.
|
github-actions
Bot
added
the
spec-auto-merge
PR Analysis Report
|
![astracat-bot[bot]](https://avatars.githubusercontent.com/in/4796231?s=60&v=4){kind=small}
There was a problem hiding this comment.
Recommend approving: the SideNav and AppShell records now describe the shipped rail collapse motion accurately, the FR6 and FR17 requirement text is unchanged, and the tests the records cite pass. One optional follow-up: add packages/core/src/SideNav/SideNavRailMotion.test.tsx and packages/core/src/motion/animatedLayout.boundary.test.ts to AppShell's verified_by, so pnpm specs:for links those tests to the record. The real-browser frame evidence both records list as pending remains the open item.
[Automated review]
| | FR9–FR12 | `AppShell.test.tsx` mobile suites; `MobileNavCloseEdgeCases.test.tsx` AppShell drawer suites | Sidenav only; both navs; heading-only TopNav; custom node | A missing toggle, duplicated items, a stale drawer, or an early hide fails. | `audit:AppShell/behavior` | | ||
| | FR13, AR3 | `AppShell.test.tsx` keyboard drawer and `useAppShellMobile` suites | Outside a shell; inside, closed and open | A wrong id link or stale state fails. | `audit:AppShell/accessibility` | | ||
| | FR14, AR4 | `AppShell.test.tsx` breakpoint continuity test | Desktop to mobile and back with a focused input | Remounting content loses the value or focus. | `audit:AppShell/behavior` | | ||
| | FR17 | `SideNavRailMotion.test.tsx`, `animatedLayout.boundary.test.ts`; real-browser frame evidence of the content area during a side nav collapse (pending) | collapse and expand with an inline side nav; Reduce Motion under a coarse and under a fine primary pointer; `fill` and a scrolled `auto` page; a theme with `reducedMotion: 'always'`; a second toggle while the swap runs; an expand whose old wrap is not copied | a visible gap between the rail and the content, a content area that animates its width or moves on its own clock, an old wrap reachable by assistive technology or left after the swap, travel under Reduce Motion, anything but an opacity-only cross-fade of 200 ms or less under Reduce Motion on a coarse pointer (DR2), or any animated property under Reduce Motion on a fine pointer (DR3) fails | `audit:AppShell/behavior` | |
There was a problem hiding this comment.
Optional: this row now cites SideNavRailMotion.test.tsx and animatedLayout.boundary.test.ts, but the record's verified_by (lines 13–19) does not list them, so pnpm specs:for on either test does not reach component:AppShell. Adding both paths to verified_by, as MobileNavCloseEdgeCases.test.tsx already is, keeps the lookup complete.
Record accuracy (follow-up to #8723, D38).
User impact
None at runtime. The SideNav and AppShell records stop saying the collapse motion is missing now that it has shipped.
Changes
component:SideNavFR6: verified bySideNavRailMotion.test.tsx, with real-browser frame evidence still pending. The compatibility line no longer says it isn't implemented.component:AppShellFR17: its current-state gap is removed. The glance and compatibility lines record it as shipped, a nonbreaking motion addition. Its verification row names the unit and boundary tests, with real-browser frame evidence pending.Writing rubric results