Repository navigation
docs(action-groups): the nav menus adopt the menu press model - #8801
Conversation
|
/approve-spec 8121034 |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
AI review status for this pull request.
|
PR Analysis Report📚 Storybook Preview🧪 Sandbox PreviewNo new or modified components detected. Bundle Size SummaryNo component packages changed. Accessibility AuditStatus: No accessibility violations detected. Visual Regression55 of 504 shot(s) changed. A change here is a question, not a failure: check whether the after is the
and 35 more. Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
There was a problem hiding this comment.
No changes needed: both record edits match the code on this head. TopNavMenu, SideNavHeading, TopNavHeading, NavHeadingMenu, BreadcrumbItem and TabMenu all mount useMenuPress and their slide tests pass, while MultiSelector still does not, so INV13 is right to keep it as the one remaining gap. The change has an exact-head spec-owner approval, and knowledge validation passes in CI.
[Automated review]
Record accuracy (follow-up to #8791).
User impact
None at runtime. Readers no longer see the nav menus listed as not yet tracking a held pointer: since #8791, TopNav's, SideNavHeading's, TopNavHeading's, NavHeadingMenu's, BreadcrumbItem's and TabMenu's menus use the menu press model.
Changes
family:action-groups: the nav-menu implementation-gap sentence is removed.architecture:interaction-modalityINV13: the gap list keeps only MultiSelector.Writing rubric results