Skip to content

docs(action-groups): the nav menus adopt the menu press model - #8801

Merged
cixzhang merged 1 commit into
mainfrom
spec/nav-menus-gap-closed
Oct 28, 2026
Merged

cixzhang merged 1 commit into
mainfrom
spec/nav-menus-gap-closed

Conversation

@cixzhang

Copy link
Copy Markdown
Contributor

Record accuracy (follow-up to #8791).

User impact

None at runtime. Readers no longer see the nav menus listed as not yet tracking a held pointer: since #8791, TopNav's, SideNavHeading's, TopNavHeading's, NavHeadingMenu's, BreadcrumbItem's and TabMenu's menus use the menu press model.

Changes

  • family:action-groups: the nav-menu implementation-gap sentence is removed.
  • architecture:interaction-modality INV13: the gap list keeps only MultiSelector.

Writing rubric results

  • R1 present tense: pass. R2 research: none. R3 verification: unchanged rows.
  • R4 rejected alternatives: none. R5 change references: none. R6 open questions: none.

@cixzhang

Copy link
Copy Markdown
Contributor Author

/approve-spec 8121034

@vercel

vercel Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
astryx Ready Ready Preview Oct 28, 2026 11:20am UTC

Request Review

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 28, 2026
@astracat-bot

astracat-bot Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

AI review status for this pull request.

Review status Updated
🟢 Reviewed (for maintainers only) Oct 28, 2026, 11:37 AM UTC

@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

PR Analysis Report

📚 Storybook Preview

View Storybook for this PR

🧪 Sandbox Preview

View Sandbox for this PR

No new or modified components detected.

Bundle Size Summary

No component packages changed.

Accessibility Audit

Status: No accessibility violations detected.

Visual Regression

55 of 504 shot(s) changed.

A change here is a question, not a failure: check whether the after is the
picture you intended. Record that review on the PR. Baseline maintenance is an
explicit dispatch of CI; this report never rewrites the baseline or adds a release gate.

component story theme mode pixels
Selector Indicator Space Bottom Sheet Narrow End RTL neutral light 753,933
Selector Indicator Space Bottom Sheet Wide Start neutral light 740,072
RichTextEditor Markdown parity: side by side probe dark 558,840
RichTextEditor Markdown parity: side by side probe light 540,756
Chat Full AI Chat probe light 230,823
Chat Full AI Chat probe dark 229,805
AppShell With Mobile Nav probe light 217,010
AppShell With Mobile Nav probe dark 216,960
Collapsible Dividers probe dark 66,445
Collapsible Dividers probe light 66,445
AppShell Playground neutral dark 65,198
AppShell Playground neutral light 63,788
Chat Default neutral dark 36,304
Chat Default neutral light 35,767
Chat Empty State probe light 23,531
Chat Empty State probe dark 22,622
ChatAutoScroll Scroll Behavior Comparison neutral dark 15,378
ChatAutoScroll Scroll Behavior Comparison neutral light 14,107
Chat With Attachments probe light 13,406
Chat With Attachments probe dark 11,232

and 35 more.


Generated by PR Enrichment workflow | Storybook | Sandbox | View full report

@astracat-bot astracat-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes needed: both record edits match the code on this head. TopNavMenu, SideNavHeading, TopNavHeading, NavHeadingMenu, BreadcrumbItem and TabMenu all mount useMenuPress and their slide tests pass, while MultiSelector still does not, so INV13 is right to keep it as the one remaining gap. The change has an exact-head spec-owner approval, and knowledge validation passes in CI.

[Automated review]

@cixzhang
cixzhang merged commit 820769d into main Oct 28, 2026
75 checks passed
vjeux added a commit to vjeux/astryx that referenced this pull request Oct 28, 2026
@github-actions
github-actions Bot deleted the spec/nav-menus-gap-closed branch October 31, 2026 06:09

This branch was successfully deployed

1 active deployment
Preview — 81210343 Deployed Oct 28, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant