Repository navigation
fix(TopNav): a mouse slide across TopNavMenu's action items selects no text - #8807
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
AI review status for this pull request.
|
PR Analysis Report📚 Storybook Preview🧪 Sandbox PreviewComponent Size
Sizes are gzip. Import counts the JavaScript the import loads eagerly; CSS counts the package stylesheet rules referenced by the modules it can load from its own package, lazily loaded ones included. Bundle Size SummaryGzip figures measure each package's entry file, not the code an import pulls in.
Accessibility AuditStatus: No accessibility violations detected. Visual Regression55 of 506 shot(s) changed. A change here is a question, not a failure: check whether the after is the
and 35 more. Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
There was a problem hiding this comment.
This looks ready to merge: userSelect: 'none' on TopNavMenu's menu stops a mouse slide across action items from selecting their text, matching the other menus, while the slide still acts once on the item it lifts on. The new Chromium case's slide leaves text selected without the fix and the case passes with it, so nothing else is needed.
[Automated review]
User impact
Someone sliding a mouse across TopNavMenu's action items (items with an
onClickand nohref), which it tracks as a held pointer since #8791, selected the item text. The selection stayed after the lift. Link items never selected text. With this change, action items select none either.Change
userSelect: 'none'on TopNavMenu's menu. Its menu holds only its own items, so no caller content is affected.NavMenusSlideSelection.a11y.chromium.spec.ts(fix(core): a mouse slide across NavHeadingMenu or TabMenu items selects no text #8802). A mouse presses the first action item's title and slides to the second; nothing may be selected while held or after the lift.Evidence
Chrome 156, the built Storybook with the new story:
Authority
family:action-groupsFR1–FR2 (the slide is the gesture) andcomponent:TopNavMenuFR11. CodeBunny noted this on #8802 at a5b3d4b.