Repository navigation
fix(Slider): range thumb names come from the catalog - #9023
Conversation
The range thumbs' accessible names were English literals. Resolve them through @astryx.slider.minimumThumb and @astryx.slider.maximumThumb (architecture:internationalization INV1a).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
meta-cla
Bot
added
the
CLA Signed
PR Analysis Report📚 Storybook Preview🧪 Sandbox PreviewModified ComponentsSlider (@astryxdesign/core) · View in Storybook
Component Size
Sizes are gzip. Import counts the JavaScript the import loads eagerly; CSS counts the package stylesheet rules referenced by the modules it can load from its own package, lazily loaded ones included. Bundle Size SummaryGzip figures measure each package's entry file, not the code an import pulls in.
Accessibility AuditStatus: The accessibility audit did not run on this pull request. It runs after merges to Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
|
AI review status for this pull request.
|
![astracat-bot[bot]](https://avatars.githubusercontent.com/in/4796231?s=60&v=4){kind=small}
There was a problem hiding this comment.
The Slider change itself looks right: the range thumb names now come from the catalog, and the new French-override test fails before the change and passes after it. One fix is needed before merge: the changeset has no [fix] tag and no contributor credit, so pnpm check:changesets fails, and the required Lint check will fail once this leaves draft. Start the changeset body with [fix] and add your @handle on its own line, or regenerate it with pnpm changeset:new.
[Automated review]
| '@astryxdesign/core': patch | ||
| --- | ||
|
|
||
| Slider: a range slider's thumb names ("Minimum value" and "Maximum value", announced to screen readers) now come from the message catalog (`@astryx.slider.minimumThumb`, `@astryx.slider.maximumThumb`), so they follow the app's locale. |
There was a problem hiding this comment.
This body needs a [fix] tag at the start and a contributor credit on its own line (spec:AST-017 FR7). Without them pnpm check:changesets fails on this file, and the required Lint check will fail once the pull request leaves draft. For example:
[fix] Slider: a range slider's thumb names ("Minimum value" and "Maximum value", announced to screen readers) now come from the message catalog (`@astryx.slider.minimumThumb`, `@astryx.slider.maximumThumb`), so they follow the app's locale.
@your-handle
There was a problem hiding this comment.
This looks ready to approve: range Slider thumb names now come from the catalog, and the new French-override test fails before the change and passes after it. The changeset now carries the [fix] tag and your credit. CI's required checks will run once the pull request leaves draft.
[Automated review]
…s-i18n # Conflicts: # packages/core/src/Slider/Slider.tsx
There was a problem hiding this comment.
This looks ready to approve: range Slider thumb names now come from the catalog, and the new French-override test fails before the change and passes after it. One optional cleanup: both strings now live in the catalog, so 'Minimum value' and 'Maximum value' can come out of the Slider entry in the no-hardcoded-i18n-string allowlist in eslint.config.js, letting lint catch them if they ever return.
[Automated review]
Part of #8955 (Slider). TimeInput and TextArea follow as separate PRs; the Table resize handle is fixed in its own PR.
User impact
Screen-reader users of a range
Slider(two thumbs) in a non-English app hear each thumb named "Minimum value" or "Maximum value" in English, mixed into otherwise translated speech, for example "Prix, Minimum value, 20".Problem and solution fit
Slider.tsx, not catalog messages.The fix resolves both names through the catalog.
Expected behavior and authority
architecture:internationalization(current) INV1a: every Astryx-owned visible or assistive string, includingaria-*values, MUST be anen.jsonkey resolved by the canonical translator.Smallest restoration
Slider.tsx: the range thumb names come fromt('@astryx.slider.minimumThumb')andt('@astryx.slider.maximumThumb').locales/en.json: those two keys, same English text, with translator descriptions. Other locales fall back to English until the translation sync (check:i18n-catalogpasses).Evidence
Slider.test.tsx"translates the range thumb names under another locale".Scope
Testing
pnpm vitest run packages/core/src/Slider;node scripts/check-i18n-catalog.mjs;node scripts/generate-i18n-runtime.mjs --check.