Repository navigation
docs(DateInput): FR14 says when a tapped row commits - #9838
Conversation
Under a finger, a tapped row commits its value when its turn ends; a keyboard or assistive-technology activation commits at once. The verification row names the three tests that check it.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
AI review status for this pull request.
|
|
/approve-spec 9a07121 |
There was a problem hiding this comment.
Recommended for approval. FR14's new sentence and verification row record what the bottom-sheet picker wheel already does: a finger's tap commits when the turn reaches the row, and a key or an assistive-technology activation commits at once. The three cited PickerWheel.test.tsx tests exist under those names and pass, the record passes knowledge validation and Prettier, and an engineering owner approved the spec text at this head. The red CI jobs stopped at the fork admission gate and wait for a maintainer's ci:run label; nothing in the change needs fixing.
[Automated review]
Exact decision needed
When does a tapped picker wheel row commit its value? Under a finger, the wheel turns onto the row (
component:DateInputFR14) and commits when the turn ends; a key or an assistive-technology activation commits at once. FR14 names the turn, not when the value commits.Existing authority searched
component:DateInputFR13, FR14, FR17 and FR18, andspec:AST-094FR4 and FR19: none names the commit moment. Open pull requests editing FR14's row: #8178 and #9706 change its text, and #9643, #9793 and #9794 re-pad it. Whichever lands later rebases one row.Decision
FR14 gains one sentence: "Under a finger, a tapped row commits its value when its turn ends; a keyboard or assistive-technology activation commits at once." The wording is the engineering owner's.
Rejected alternatives
onChangewould arrive while the wheel still shows the old row, unlike the iOS picker.Claim scope and non-goals
Only the commit moment of a tap, a key and an assistive-technology activation. FR14's turn, FR17 and FR18 are unchanged.
Evidence and implementation relationship
Since #8159 the wheel behaves so. FR14's verification row now names the three
PickerWheel.test.tsxtests that check it, and its states and failure clause name those inputs:Writing rubric results
Over
component:DateInputFR14's two rows:Scope
Validation
pnpm check:knowledge: aligned.git diff --check: clean.