Skip to content

test(Tokenizer): the sheet-row test passes presentation, not the removed experimental prop - #9849

Closed
cixzhang wants to merge 1 commit into
mainfrom
fix/tokenizer-sheet-test-presentation
Closed

cixzhang wants to merge 1 commit into
mainfrom
fix/tokenizer-sheet-test-presentation

Conversation

@cixzhang

@cixzhang cixzhang commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Maintainer impact

Main's typecheck fails, so every pull request that merges now reports a red main. packages/core/src/Tokenizer/TokenizerBottomSheet.test.tsx:1814 passes experimental={{presentation: 'bottom-sheet'}}, and that prop no longer exists:

src/Tokenizer/TokenizerBottomSheet.test.tsx(1814,11): error TS2769: No overload matches this call.
  Property 'experimental' does not exist on type 'IntrinsicAttributes & TokenizerProps<…>'.

Cause

Two pull requests merged eight minutes apart, and each passed its own checks:

Change

The test uses presentation="bottom-sheet", the spelling the other tests in this file already use. Test only: no product code and no Changeset.

Scope

  • No intended public API, product behavior, visual direction, or policy change.
  • Public text and artifacts contain no internal Meta context.

Testing

  • No other source file passes experimental={{presentation…}} to Tokenizer. The remaining matches are the upgrade codemod's fixtures, which use the old spelling on purpose.
  • CI typecheck on this pull request.

Posted by Cindy's agent on her behalf.

…ved experimental prop

#9808 added the test with experimental.presentation; #9836 removed that
prop. Each was green alone; together main typecheck fails (TS2769).
@vercel

vercel Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
astryx Ready Ready Preview Nov 4, 2026 1:25am UTC

Request Review

@astracat-bot

astracat-bot Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

AI review status for this pull request.

Review status Updated
🔄 In progress (for maintainers only) Nov 4, 2026, 1:14 AM UTC

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 4, 2026
@cixzhang cixzhang added the ci:run A maintainer lets this outside contributor's pull request run CI (AST-030 FR17) label Nov 4, 2026
@cixzhang

cixzhang commented Nov 4, 2026

Copy link
Copy Markdown
Contributor Author

Closing as a duplicate of #9847, which makes the same one-line fix and opened first. Posted by Cindy's agent on her behalf.

@cixzhang cixzhang closed this Nov 4, 2026
@cixzhang
cixzhang deleted the fix/tokenizer-sheet-test-presentation branch November 4, 2026 01:16

This branch was successfully deployed

1 active deployment
Preview — 5dac9aeb Deployed Nov 4, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:run A maintainer lets this outside contributor's pull request run CI (AST-030 FR17) CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant