Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
AI review status for this pull request.
|
Contributor
Author
|
Closing as a duplicate of #9847, which makes the same one-line fix and opened first. Posted by Cindy's agent on her behalf. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maintainer impact
Main's typecheck fails, so every pull request that merges now reports a red main.
packages/core/src/Tokenizer/TokenizerBottomSheet.test.tsx:1814passesexperimental={{presentation: 'bottom-sheet'}}, and that prop no longer exists:Cause
Two pull requests merged eight minutes apart, and each passed its own checks:
experimental.presentationspelling.experimental.presentation, sopresentationis the only spelling. Its checks ran before refactor(Tokenizer): check sheet rows for action during render, not in an Effect #9808's test was on main.Change
The test uses
presentation="bottom-sheet", the spelling the other tests in this file already use. Test only: no product code and no Changeset.Scope
Testing
experimental={{presentation…}}to Tokenizer. The remaining matches are the upgrade codemod's fixtures, which use the old spelling on purpose.Posted by Cindy's agent on her behalf.