Repository navigation
test(Tokenizer): the sheet-row action test passes presentation, not the removed experimental prop - #9850
Closed
imdreamrunner wants to merge 1 commit into
Closed
test(Tokenizer): the sheet-row action test passes presentation, not the removed experimental prop#9850imdreamrunner wants to merge 1 commit into
imdreamrunner wants to merge 1 commit into
Conversation
…he removed experimental prop
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
AI review status for this pull request.
|
Contributor
Author
|
Closing as a duplicate of #9847, which makes the same one-line change and was opened first. |
meta-cla
Bot
added
the
CLA Signed
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maintainer impact
mainfailstypecheck,test,test-node (2/4)andbuild. #9808 added a Tokenizer sheet test that passesexperimental={{presentation: 'bottom-sheet'}}, and #9836, which merged after it, removed Tokenizer'sexperimentalprop. The two PRs did not conflict textually, so both merged. Every open PR now inherits the red base:TokenizerBottomSheet.test.tsx(1814,11): error TS2769: No overload matches this call.At runtime the test also fails, because the field ignoresexperimentaland renders the inline combobox, so the test cannot find the sheet trigger.Intended invariant
Tokenizer takes only the stable
presentationprop (component:TokenizerDEC-3, Compatibility). The test checks the sheet presentation's development warning for a rowaction. That behavior is unchanged.Change
The test passes
presentation="bottom-sheet"in place ofexperimental={{presentation: 'bottom-sheet'}}. This is a one-line test change; product code does not change.Evidence
typecheckjob on main and on chore(changeset): the Lab removal note names Core's presentation sheets #9846 reportssrc/Tokenizer/TokenizerBottomSheet.test.tsx(1814,11): error TS2769.git grep -nE "experimental=\{\{presentation|experimental: \{presentation|experimental\.presentation" -- packages apps docs/specson main finds this line only, outside the codemod and its tests.Scope
Testing
CI runs
typecheckand the Tokenizer suites on this PR.