Skip to content

[Nexthop][m4340nhp] Add the fan_service config - #1874

Open
marif-nexthop wants to merge 11 commits into
meta:mainfrom
nexthop-ai:marif.fboss-m4340nhp-fan-config
Open

marif-nexthop wants to merge 11 commits into
meta:mainfrom
nexthop-ai:marif.fboss-m4340nhp-fan-config

Conversation

@marif-nexthop

Copy link
Copy Markdown
Contributor

Pre-submission checklist

  • I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running pip install -r requirements-dev.txt && pre-commit install
  • pre-commit run

Summary

PR commit stack:

  1. [Nexthop][m4340nhp] Add the platform_manager config #1871
  2. [Nexthop][m4340nhp] Add the sensor_service and led_manager configs #1872
  3. This (top of stack)
  • Cache the last ASIC temperature readings between SAI reads. The agent returned an empty map inside its read interval, so the ASIC temperatures in FSDB were empty most of the time.
  • Start fan_service with the FSDB subscription flags, so that it reads sensor data, including the agent's ASIC temperatures, from FSDB.
  • Accept the agent's asic_temp_<n>_<n> ASIC temperature sensors in the fan_service cross-config check. The agent publishes these readings, so they are not in sensor_service.json.
  • Skip shutdown sensors without readings in the fan_service overtemp check. Before, one such sensor disabled the check for all of them.
  • Add the m4340nhp fan_service.json and its ConfigLibTest check.

Test Plan

fan_service_sw_test and cross_config_validator_test pass, and the build-time config generator accepts the config.

@marif-nexthop
marif-nexthop requested review from a team as code owners October 30, 2026 21:19
@github-actions github-actions Bot added nexthop project:m4340nhp FBOSS project: m4340nhp labels Oct 30, 2026
@meta-cla meta-cla Bot added the CLA Signed label Oct 30, 2026
@marif-nexthop
marif-nexthop force-pushed the marif.fboss-m4340nhp-fan-config branch from 3e98e19 to df4bed1 Compare October 31, 2026 02:16

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant