Repository navigation
[Nexthop][m4340nhp] Add the fan_service config - #1874
Open
marif-nexthop wants to merge 11 commits into
Open
marif-nexthop wants to merge 11 commits into
marif-nexthop wants to merge 11 commits into
Conversation
marif-nexthop
force-pushed
the
marif.fboss-m4340nhp-fan-config
branch
from
October 31, 2026 02:16
3e98e19 to
df4bed1
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
PR commit stack:
asic_temp_<n>_<n>ASIC temperature sensors in the fan_service cross-config check. The agent publishes these readings, so they are not insensor_service.json.fan_service.jsonand itsConfigLibTestcheck.Test Plan
fan_service_sw_testandcross_config_validator_testpass, and the build-time config generator accepts the config.