Repository navigation
[Nexthop][m4340nhp] Build VOQ system ports from the TM slot the Qumran4D SAI assigned - #1880
Open
marif-nexthop wants to merge 2 commits into
Open
marif-nexthop wants to merge 2 commits into
marif-nexthop wants to merge 2 commits into
Conversation
marif-nexthop
force-pushed
the
marif.fboss-q4d-system-port-tm-slot
branch
from
October 31, 2026 01:48
a086982 to
46bc4e8
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
PR commit stack:
The Qumran4D SAI assigns the TM slot of a port created at runtime itself, as the lowest free index in the port's core. The agent builds the port's VOQ system port from the platform mapping's core port index, which can match only one creation order. Any other breakout fails when the agent creates the system port.
The new
SYSTEM_PORT_CORE_INDEX_FROM_PORTfeature, set only for Qumran4D, makesSaiSystemPortManagerbuild a local interface port's system port from the core and core port index that the SAI reports for the port. It falls back to the platform mapping when the port does not exist yet. Recycle, management and eventor ports, remote system ports and the softwareSystemPortstate are unchanged.Test Plan
On a
m4340nhpdevice, breaking a cage out to 2x400G, 4x200G or 8x100G brings all of its ports up, and they stay up across a warm boot. Without this change, the 2x400G breakout makes the hardware agent crash-loop with the error above. The changed files build in the OSS build.