Repository navigation
[Nexthop][m4340nhp] Skip ports without PRBS state in show interface prbs state - #1884
Open
marif-nexthop wants to merge 1 commit into
Open
marif-nexthop wants to merge 1 commit into
marif-nexthop wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
With no ports given,
fboss2 show interface prbs statelists every port and looks up its state for each component. The agent and qsfp_service report PRBS state only for the ports they serve, so the command failed on the first port without an entry, such as a recycle port.The command now skips missing (port, component) pairs and leaves out ports with no state at all. A port named on the command line with no PRBS state still fails as before.
Test Plan
The new
CmdShowInterfacePrbsTestcases infboss2_cmd_testpass, and they fail without the fix. On am4340nhpdevice,fboss2 show interface prbs statenow lists 85 ports instead of failing.