Repository navigation
[Nexthop][m4340nhp] Run AgentPortProfileTest on VOQ switches and Qumran4D - #1886
Open
marif-nexthop wants to merge 2 commits into
Open
marif-nexthop wants to merge 2 commits into
marif-nexthop wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
Two changes let
AgentPortProfileTestrun on m4340nhp.initialConfig()instead ofoneL3IntfTwoPortConfig(). That helper adds a VLAN interface, but VOQ switches have no VLANs, so every profile test aborted at config apply withNo vlan found for : 2000.initialConfig(), as it already does on Chenab. A profile with a different lane count makesSaiPortManagerre-create the port while its port RIF is still attached, and the Qumran4D SDK does not remove a port that a RIF references, so the hw agent aborted on the 400G-4 and 200G-2 profiles.Test Plan
Tested on a
m4340nhpdevice.AgentPortProfileTestpasses on cold and warm boot for all six profiles that its ports support, and skips the rest.