Skip to content

fix Implement static checking for model_validate in pydantic #1123 #3390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
asukaminato0721 wants to merge 3 commits into
base: main
Choose a base branch
from
+604 −0
Open

fix Implement static checking for model_validate in pydantic #1123 #3390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
16ab8c5
fix
asukaminato0721 May 14, 2026
87ad0c3
use Gas
asukaminato0721 May 14, 2026
aadd153
fix api change
asukaminato0721 Oct 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions pyrefly/lib/alt/call.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3112,6 +3112,13 @@ impl<'ctx, 'answer, Ans: LookupAnswer> AnswersSolver<'ctx, 'answer, Ans> {
"`NotImplemented` is not callable. Did you mean `NotImplementedError`?".to_owned(),
);
}
self.check_pydantic_model_validate_constraints(
ty,
&x.arguments.args,
&x.arguments.keywords,
x.arguments.range,
errors,
);
Comment on lines +3115 to +3121
match ty.callee_kind() {
Some(CalleeKind::Function(FunctionKind::AssertType)) => self
.call_assert_type(
Expand Down
13 changes: 13 additions & 0 deletions pyrefly/lib/alt/class/dataclass.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,19 @@ impl<'ctx, 'answer, Ans: LookupAnswer> AnswersSolver<'ctx, 'answer, Ans> {
{
fields.insert(MODEL_CONSTRUCT, model_construct);
}
if metadata.is_pydantic_model()
&& !self
.get_class_fields(cls)
.is_some_and(|fields| fields.contains(&Name::new_static("model_validate")))
{
let root_model_type = self
.get_pydantic_root_model_type_via_mro(cls, metadata)
.map(|(ty, _)| ty);
fields.insert(
Name::new_static("model_validate"),
Comment on lines +224 to +233
self.get_pydantic_model_validate(cls, dataclass, root_model_type),
);
}
let dataclass_fields_type = self.stdlib.dict(
self.heap.mk_class_type(self.stdlib.str().clone()),
self.heap.mk_any_implicit(),
Expand Down
Loading
Loading