Repository navigation
fix Find-references on library/third-party code #1399 - #4194
Open
asukaminato0721 wants to merge 2 commits into
Open
asukaminato0721 wants to merge 2 commits into
asukaminato0721 wants to merge 2 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
|
This pull request has been imported. If you are a Meta employee, you can view this in D115174725. (Because this pull request was imported automatically, there will not be any future comments.) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
asukaminato0721
force-pushed
the
1399
branch
2 times, most recently
from
October 27, 2026 11:29
535950d to
743115d
Compare
This comment has been minimized.
This comment has been minimized.
stroxler
requested changes
Oct 29, 2026
stroxler
left a comment
stroxler
left a comment
Contributor
There was a problem hiding this comment.
Thanks! This looks like a promising direction. I think there are a couple of gaps:
- Include the stub declaration when renaming. Renaming a symbol from its
.pysource must update the corresponding.pyideclaration along with consumers. Keep declaration suppression specific to Find References, and add a paired-file rename test. - Validate lexical scope before mapping source symbols to stubs. Only map actual module-level or class-level declarations—not parameters, local variables, or nested functions that happen to share a public symbol’s name. Add negative tests for these name collisions.
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1399
Find References from third-party .py source now searches references indexed against its matching .pyi stub.
Preserves the source declaration and merges workspace references.
Test Plan
add test