Repository navigation
test: document desugared classmethod binding bugs - #5048
asukaminato0721 wants to merge 1 commit into
Conversation
|
This pull request has been imported. If you are a Meta employee, you can view this in D122390395. (Because this pull request was imported automatically, there will not be any future comments.) |
Merging this PR will not alter performance
Comparing Footnotes
|
This comment has been minimized.
This comment has been minimized.
4bd251f to
2469a29
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2469a29 to
264ce53
Compare
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
kinto0
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
kinto0
left a comment
There was a problem hiding this comment.
thank you for splitting this. sorry it took a while, I wanted to verify this actually reproduced the bug and it looks like it does. I'll merge this for now
|
This pull request has been merged in 906d9a2. |
Summary
Desugared classmethod assignments retain instance binding. The test expects the current incorrect diagnostics and documents class binding, subclass-aware results, and class attribute initialization as the intended behavior.
The
testcase!regressions usebug =markers and comments documenting the correct behavior. These are passing tests of known bugs, following the repository test guidance.The complete implementation and regression tests remain in PR #4796. Related issue: #3362.
Validation
Based on upstream
mainatef6de648bce0dc6dcca0a21a9fbb7490f23ecce8.cargo test -p pyrefly --lib -- test_desugared_classmethod— passed.python3 test.py --no-test --no-tensor-shapes --no-conformance --no-jsonschema --no-extension— passed.