Repository navigation
Renderdag column parts - #1483
Open
rockboynton wants to merge 2 commits into
Open
rockboynton wants to merge 2 commits into
rockboynton wants to merge 2 commits into
Conversation
A prefix line renderer joins all the columns of a link, term, or pad line into one text part. So a caller cannot tell which column drew each character, and it cannot style each edge, for example with one color for each column. Add a ColumnText part that carries the column of its edge, and make the three renderers give one for each column. A connector between two columns goes to the column whose line ends in the link line, or else to the column farther from the node. That way a fork or a merge takes the color of its branch. The rendered text does not change.
The text output stage writes each line into a String, which drops the column of each piece. A caller that styles each column through its own writer, such as a CLI formatter, cannot use the stage. It also cannot copy the stage, because the padding and message rules are private. Add write_next_lines, which gives each line to a callback as a list of pieces that keep their columns. The stage still trims trailing whitespace, now across pieces. write_next_text keeps its signature and calls the new method, so current callers see no change.
6 tasks done
|
This pull request has been imported. If you are a Meta employee, you can view this in D128852423. (Because this pull request was imported automatically, there will not be any future comments.) |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose each graph-line segment's owning column so callers can color graph edges by column.
Here is example of what it looks like when used in jj:
jj PR: jj-vcs/jj#10548