fix(auth): preserve config on transient server/network errors - #253
Open
prathamesh04 wants to merge 1 commit into
Open
fix(auth): preserve config on transient server/network errors#253prathamesh04 wants to merge 1 commit into
prathamesh04 wants to merge 1 commit into
Conversation
The validateToken function was deleting the cached config for any exception thrown by api.validate(), including temporary outages, DNS failures, or non-auth server errors. This forced users to re-login even when their credentials were valid. Changes: - Distinguish auth errors (401, 430, JWT-related) from transient errors - Preserve cached config for network failures and server errors - Show warning message for transient errors instead of error - Extract invalidateConfig helper function - Add isJwtError helper to detect JWT-specific errors Fixes metacall#232
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
validateTokenfunction was deleting the cached config for any exception thrown byapi.validate(), including temporary outages, DNS failures, or non-auth server errors. This forced users to re-login even when their credentials were valid.Fixes #232
Changes
invalidateConfighelper functionisJwtErrorhelper to detect JWT-specific errorsChecklist
npm run build)npm run lint)