Skip to content

Parse source_release and source_revision in security.txt - #715

Merged
kingsznhone merged 2 commits into
michaelhly:masterfrom
wavebyrd:fix/security-txt-source-release
Oct 22, 2026
Merged

kingsznhone merged 2 commits into
michaelhly:masterfrom
wavebyrd:fix/security-txt-source-release

Conversation

@wavebyrd

Copy link
Copy Markdown
Contributor

parse_security_txt() silently drops source_release and source_revision. Both are optional fields of the security_txt! format (see parse() in neodyme-labs/solana-security-txt), but SecurityTxt has no attribute for them, so the parser skips them as unknown keys and a program's release tag and commit never show up.

Added the two fields after source_code and extended the existing parse test with them; it fails with AttributeError without the change.

@codecov

codecov Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.40%. Comparing base (aee730b) to head (507ec02).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #715   +/-   ##
=======================================
  Coverage   95.40%   95.40%           
=======================================
  Files          25       25           
  Lines        1914     1916    +2     
=======================================
+ Hits         1826     1828    +2     
  Misses         88       88           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kingsznhone
kingsznhone merged commit 44fe118 into michaelhly:master Oct 22, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants