Repository navigation
Fix parse_security_txt silently truncating data when the footer is missing - #716
Merged
kingsznhone merged 1 commit intoOct 22, 2026
Merged
Conversation
parse_security_txt used data.find() for the footer and sliced up to its result. When the footer was missing, find() returned -1 and the slice dropped the last byte of the program data instead of failing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #716 +/- ##
=======================================
Coverage 95.31% 95.31%
=======================================
Files 25 25
Lines 1919 1921 +2
=======================================
+ Hits 1829 1831 +2
Misses 90 90 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parse_security_txtfinds the footer withdata.find(footer_bytes, ...)and slices up to the result. When the footer is missing,find()returns-1, sodata[start:-1]silently drops the last byte and parsing continues on truncated content instead of reporting that the section is incomplete.This raises
NoSecurityTxtFoundErrorwhen the footer is not found, the same error already used when the header is missing.How tested:
test_parse_security_text_without_footerfails onmasterand passes with the fix.pytest tests/unit: 140 passed.ruff checkandruff format --checkclean.🤖 Generated with Claude Code